[PATCH] x86: fix missing declartion of io_apic_irqs

Zhang Kunbo posted 1 patch 1 year, 2 months ago
arch/x86/kernel/i8259.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] x86: fix missing declartion of io_apic_irqs
Posted by Zhang Kunbo 1 year, 2 months ago
arch/x86/kernel/i8259.c should include arch/x86/include/asm/io_apic.h
 for declaration of io_apic_irqs. This fix the sparse warning:

arch/x86/kernel/i8259.c:57:15: warning: symbol 'io_apic_irqs' was not declared. Should it be static?

Signed-off-by: Zhang Kunbo <zhangkunbo@huawei.com>
---
 arch/x86/kernel/i8259.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index c20d1832c481..2bade73f49e3 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -23,6 +23,7 @@
 #include <asm/desc.h>
 #include <asm/apic.h>
 #include <asm/i8259.h>
+#include <asm/io_apic.h>
 
 /*
  * This is the 'legacy' 8259A Programmable Interrupt Controller,
-- 
2.34.1
Re: [PATCH] x86: fix missing declartion of io_apic_irqs
Posted by Markus Elfring 1 year, 2 months ago
> arch/x86/kernel/i8259.c should include arch/x86/include/asm/io_apic.h
>  for declaration of io_apic_irqs. This fix the sparse warning:
…

Please avoid a typo in the summary phrase accordingly.


See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12#n94

Regards,
Markus