[PATCH v3 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

Xin Liu posted 3 patches 1 year, 2 months ago
[PATCH v3 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node
Posted by Xin Liu 1 year, 2 months ago
Add watchdog clock on the Qualcomm QCS8300 Ride platform.

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 7eed19a694c3..d4e4c7a8b453 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -265,3 +265,7 @@ &ufs_mem_phy {
 	vdda-pll-supply = <&vreg_l5a>;
 	status = "okay";
 };
+
+&watchdog {
+    clocks = <&sleep_clk>;
+};
-- 
2.34.1
Re: [PATCH v3 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node
Posted by Dmitry Baryshkov 1 year, 2 months ago
On Mon, Nov 25, 2024 at 05:35:03PM +0800, Xin Liu wrote:
> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
> 
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 7eed19a694c3..d4e4c7a8b453 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>  	vdda-pll-supply = <&vreg_l5a>;
>  	status = "okay";
>  };
> +
> +&watchdog {
> +    clocks = <&sleep_clk>;
> +};

I'd really prefer to have this in the SoC dtsi. It's not a part that can
change between boards.

-- 
With best wishes
Dmitry
Re: [PATCH v3 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node
Posted by Xin Liu 1 year, 2 months ago

在 2024/11/26 0:45, Dmitry Baryshkov 写道:
> I'd really prefer to have this in the SoC dtsi. It's not a part that can
> change between boards.

I think you're right, this clock won't change because of the board The 
reason for placing it on the board is that sleep_clk is defined on the 
board. The following link is the suggestion you once provided:
https://lore.kernel.org/all/4kopdkvbkrpcpzwteezm427ml5putqvzsnfkpmg76spsple7l5@mg7v3ihwxnit/