[v3] Add support for attaching a regulator to w1: ds2482

[PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

Posted by Kryštof Černý via B4 Relay 1 year, 2 months ago

From: Kryštof Černý <cleverline1mc@gmail.com>

ds2482 has a VCC pin, accepting 2.9-5.5 V.

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
index 422becc6e1fa8d58665c5586ebdc611cd0b2c760..fe6b3f9a3f8bbd00366c3e36aad3ffa72ec1a31f 100644
--- a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
+++ b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
@@ -25,6 +25,8 @@ properties:
   reg:
     maxItems: 1
 
+  vcc-supply: true
+
 required:
   - compatible
   - reg

-- 
2.39.5

Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply propertyy

Posted by Conor Dooley 1 year, 2 months ago

On Sun, Nov 24, 2024 at 05:21:37PM +0100, Kryštof Černý via B4 Relay wrote:
> From: Kryštof Černý <cleverline1mc@gmail.com>
> 
> ds2482 has a VCC pin, accepting 2.9-5.5 V.
> 
> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

Posted by Stefan Wahren 1 year, 2 months ago

Hi Kryštof,

[fix messageid]

> From: Kryštof Černý <cleverline1mc@gmail.com>
>
> ds2482 has a VCC pin, accepting 2.9-5.5 V.
>
> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>

Sorry, I'm not able to reply from my chargebyte address.

I'm fine with the content of this patch, but in case you need to send a
v4 please make this the first patch of the series.

Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

Posted by Kryštof Černý 1 year, 2 months ago

Hello Stefan,

> Hi Kryštof,
> 
> [fix messageid]
> 
>> From: Kryštof Černý <cleverline1mc@gmail.com>
>>
>> ds2482 has a VCC pin, accepting 2.9-5.5 V.
>>
>> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
> 
> Sorry, I'm not able to reply from my chargebyte address.
> 
> I'm fine with the content of this patch, but in case you need to send a
> v4 please make this the first patch of the series.

I will do it, could you point me to the documentation, where this is 
specified, so I can avoid similar mistakes in the future?

> Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

Thank you for your reviews,
Kryštof Černý

Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

Posted by Krzysztof Kozlowski 1 year, 2 months ago

On 25/11/2024 23:39, Kryštof Černý wrote:
> Hello Stefan,
> 
>> Hi Kryštof,
>>
>> [fix messageid]
>>
>>> From: Kryštof Černý <cleverline1mc@gmail.com>
>>>
>>> ds2482 has a VCC pin, accepting 2.9-5.5 V.
>>>
>>> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
>>
>> Sorry, I'm not able to reply from my chargebyte address.
>>
>> I'm fine with the content of this patch, but in case you need to send a
>> v4 please make this the first patch of the series.
> 
> I will do it, could you point me to the documentation, where this is 
> specified, so I can avoid similar mistakes in the future?
First, this is common sense: all ABI documentation must come before the
user actually starts using. Otherwise the series are not bisectable -
testing commit implementing ABI will point to errors in missing ABI
documentation.

Second, doc is submitting patches in bindings directory. Please also
read writing bindings doc, in the same place.

Best regards,
Krzysztof