1. Patchew
  2. linux
  3. View series

[RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF

Armin Wolf posted 1 patch 1 year, 2 months ago 
drivers/platform/x86/asus-nb-wmi.c | 1 +
1 file changed, 1 insertion(+)
[RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
Posted by Armin Wolf 1 year, 2 months ago 
On the Asus X541UAK an unknown event 0xCF is emited when the charger
is plugged in. This is caused by the following AML code:

    If (ACPS ())
    {
        ACPF = One
        Local0 = 0x58
        If (ATKP)
        {
            ^^^^ATKD.IANE (0xCF)
        }
    }
    Else
    {
        ACPF = Zero
        Local0 = 0x57
    }

    Notify (AC0, 0x80) // Status Change
    If (ATKP)
    {
        ^^^^ATKD.IANE (Local0)
    }

    Sleep (0x64)
    PNOT ()
    Sleep (0x0A)
    NBAT (0x80)

Ignore the 0xCF event to silence the unknown event warning.

Reported-by: Pau Espin Pedrol <pespin@espeweb.net>
Closes: https://lore.kernel.org/platform-driver-x86/54d4860b-ec9c-4992-acf6-db3f90388293@espeweb.net
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
 drivers/platform/x86/asus-nb-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index ef04d396f61c..a5933980ade3 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -623,6 +623,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
 	{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
 	{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
 	{ KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
+	{ KE_IGNORE, 0xCF, },	/* AC mode */
 	{ KE_KEY, 0xFA, { KEY_PROG2 } },           /* Lid flip action */
 	{ KE_KEY, 0xBD, { KEY_PROG2 } },           /* Lid flip action on ROG xflow laptops */
 	{ KE_END, 0},
--
2.39.5
Re: [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
Posted by Ilpo Järvinen 1 year, 2 months ago 
On Sat, 23 Nov 2024 23:47:00 +0100, Armin Wolf wrote:

> On the Asus X541UAK an unknown event 0xCF is emited when the charger
> is plugged in. This is caused by the following AML code:
> 
>     If (ACPS ())
>     {
>         ACPF = One
>         Local0 = 0x58
>         If (ATKP)
>         {
>             ^^^^ATKD.IANE (0xCF)
>         }
>     }
>     Else
>     {
>         ACPF = Zero
>         Local0 = 0x57
>     }
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
      commit: e9fba20c29e27dc99e55e1c550573a114561bf8c

--
 i.
Re: [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
Posted by Hans de Goede 1 year, 2 months ago 
Hi,

On 23-Nov-24 11:47 PM, Armin Wolf wrote:
> On the Asus X541UAK an unknown event 0xCF is emited when the charger
> is plugged in. This is caused by the following AML code:
> 
>     If (ACPS ())
>     {
>         ACPF = One
>         Local0 = 0x58
>         If (ATKP)
>         {
>             ^^^^ATKD.IANE (0xCF)
>         }
>     }
>     Else
>     {
>         ACPF = Zero
>         Local0 = 0x57
>     }
> 
>     Notify (AC0, 0x80) // Status Change
>     If (ATKP)
>     {
>         ^^^^ATKD.IANE (Local0)
>     }
> 
>     Sleep (0x64)
>     PNOT ()
>     Sleep (0x0A)
>     NBAT (0x80)
> 
> Ignore the 0xCF event to silence the unknown event warning.
> 
> Reported-by: Pau Espin Pedrol <pespin@espeweb.net>
> Closes: https://lore.kernel.org/platform-driver-x86/54d4860b-ec9c-4992-acf6-db3f90388293@espeweb.net
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans




> ---
>  drivers/platform/x86/asus-nb-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index ef04d396f61c..a5933980ade3 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -623,6 +623,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>  	{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
>  	{ KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
> +	{ KE_IGNORE, 0xCF, },	/* AC mode */
>  	{ KE_KEY, 0xFA, { KEY_PROG2 } },           /* Lid flip action */
>  	{ KE_KEY, 0xBD, { KEY_PROG2 } },           /* Lid flip action on ROG xflow laptops */
>  	{ KE_END, 0},
> --
> 2.39.5
>
Re: [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
Posted by Armin Wolf 1 year, 2 months ago 
Am 25.11.24 um 10:39 schrieb Hans de Goede:

> Hi,
>
> On 23-Nov-24 11:47 PM, Armin Wolf wrote:
>> On the Asus X541UAK an unknown event 0xCF is emited when the charger
>> is plugged in. This is caused by the following AML code:
>>
>>      If (ACPS ())
>>      {
>>          ACPF = One
>>          Local0 = 0x58
>>          If (ATKP)
>>          {
>>              ^^^^ATKD.IANE (0xCF)
>>          }
>>      }
>>      Else
>>      {
>>          ACPF = Zero
>>          Local0 = 0x57
>>      }
>>
>>      Notify (AC0, 0x80) // Status Change
>>      If (ATKP)
>>      {
>>          ^^^^ATKD.IANE (Local0)
>>      }
>>
>>      Sleep (0x64)
>>      PNOT ()
>>      Sleep (0x0A)
>>      NBAT (0x80)
>>
>> Ignore the 0xCF event to silence the unknown event warning.
>>
>> Reported-by: Pau Espin Pedrol <pespin@espeweb.net>
>> Closes: https://lore.kernel.org/platform-driver-x86/54d4860b-ec9c-4992-acf6-db3f90388293@espeweb.net
>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans

Any updates on this?

Thanks,
Armin Wolf

>> ---
>>   drivers/platform/x86/asus-nb-wmi.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
>> index ef04d396f61c..a5933980ade3 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -623,6 +623,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>>   	{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>>   	{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
>>   	{ KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
>> +	{ KE_IGNORE, 0xCF, },	/* AC mode */
>>   	{ KE_KEY, 0xFA, { KEY_PROG2 } },           /* Lid flip action */
>>   	{ KE_KEY, 0xBD, { KEY_PROG2 } },           /* Lid flip action on ROG xflow laptops */
>>   	{ KE_END, 0},
>> --
>> 2.39.5
>>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.