[v2] QPIC v2 fixes for SDX75

[PATCH v2 0/3] QPIC v2 fixes for SDX75

Posted by Md Sadre Alam 1 year, 2 months ago

v2:
 * Updated commit message
 * Added stable kernel tag
 * Added Fixes tag
 * Renamed the variable from offset_from_qpic to nandc_offset
 * Set buf_count to 512 in the parameter page read
 * Replaced the buf_count value of 512 with the len in bytes 

v1:
 * These patches will fix the following:
 * 1) onfi param page read which was broken by exec_op() patch.
 * 2) Fixed offset passed to BAM from QPIC base

Md Sadre Alam (3):
  mtd: rawnand: qcom: Pass 18 bit offset from QPIC base address to BAM
  mtd: rawnand: qcom: Fix onfi param page read
  mtd: rawnand: qcom: Fix read len for onfi param page

 drivers/mtd/nand/raw/qcom_nandc.c | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/3] QPIC v2 fixes for SDX75

Posted by Manivannan Sadhasivam 1 year, 1 month ago

On Fri, Nov 22, 2024 at 02:29:30PM +0530, Md Sadre Alam wrote:
> v2:
>  * Updated commit message
>  * Added stable kernel tag
>  * Added Fixes tag
>  * Renamed the variable from offset_from_qpic to nandc_offset
>  * Set buf_count to 512 in the parameter page read
>  * Replaced the buf_count value of 512 with the len in bytes 
> 
> v1:
>  * These patches will fix the following:
>  * 1) onfi param page read which was broken by exec_op() patch.
>  * 2) Fixed offset passed to BAM from QPIC base
> 
> Md Sadre Alam (3):
>   mtd: rawnand: qcom: Pass 18 bit offset from QPIC base address to BAM
>   mtd: rawnand: qcom: Fix onfi param page read
>   mtd: rawnand: qcom: Fix read len for onfi param page
> 

Do you plan to respin this series? FYI, these are regressions, so should go in
early as possible.

- Mani

>  drivers/mtd/nand/raw/qcom_nandc.c | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
> 
> -- 
> 2.34.1
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2 0/3] QPIC v2 fixes for SDX75

Posted by Md Sadre Alam 1 year, 1 month ago


On 12/20/2024 3:00 PM, Manivannan Sadhasivam wrote:
> On Fri, Nov 22, 2024 at 02:29:30PM +0530, Md Sadre Alam wrote:
>> v2:
>>   * Updated commit message
>>   * Added stable kernel tag
>>   * Added Fixes tag
>>   * Renamed the variable from offset_from_qpic to nandc_offset
>>   * Set buf_count to 512 in the parameter page read
>>   * Replaced the buf_count value of 512 with the len in bytes
>>
>> v1:
>>   * These patches will fix the following:
>>   * 1) onfi param page read which was broken by exec_op() patch.
>>   * 2) Fixed offset passed to BAM from QPIC base
>>
>> Md Sadre Alam (3):
>>    mtd: rawnand: qcom: Pass 18 bit offset from QPIC base address to BAM
>>    mtd: rawnand: qcom: Fix onfi param page read
>>    mtd: rawnand: qcom: Fix read len for onfi param page
>>
> 
> Do you plan to respin this series? FYI, these are regressions, so should go in
> early as possible.
Waiting for SPI NAND series patches [1] to be merged (raw nand change 
patch 2-5). On top of that will repost these patches.

Thanks,
Alam.

1. 
https://lore.kernel.org/linux-arm-msm/20241120091507.1404368-1-quic_mdalam@quicinc.com/

> 
> - Mani
> 
>>   drivers/mtd/nand/raw/qcom_nandc.c | 23 ++++++++++++++++++-----
>>   1 file changed, 18 insertions(+), 5 deletions(-)
>>
>> -- 
>> 2.34.1
>>
>

Re: [PATCH v2 0/3] QPIC v2 fixes for SDX75

Posted by Manivannan Sadhasivam 1 year, 1 month ago

On Tue, Dec 24, 2024 at 10:52:03AM +0530, Md Sadre Alam wrote:
> 
> 
> On 12/20/2024 3:00 PM, Manivannan Sadhasivam wrote:
> > On Fri, Nov 22, 2024 at 02:29:30PM +0530, Md Sadre Alam wrote:
> > > v2:
> > >   * Updated commit message
> > >   * Added stable kernel tag
> > >   * Added Fixes tag
> > >   * Renamed the variable from offset_from_qpic to nandc_offset
> > >   * Set buf_count to 512 in the parameter page read
> > >   * Replaced the buf_count value of 512 with the len in bytes
> > > 
> > > v1:
> > >   * These patches will fix the following:
> > >   * 1) onfi param page read which was broken by exec_op() patch.
> > >   * 2) Fixed offset passed to BAM from QPIC base
> > > 
> > > Md Sadre Alam (3):
> > >    mtd: rawnand: qcom: Pass 18 bit offset from QPIC base address to BAM
> > >    mtd: rawnand: qcom: Fix onfi param page read
> > >    mtd: rawnand: qcom: Fix read len for onfi param page
> > > 
> > 
> > Do you plan to respin this series? FYI, these are regressions, so should go in
> > early as possible.
> Waiting for SPI NAND series patches [1] to be merged (raw nand change patch
> 2-5). On top of that will repost these patches.

This series fixes regression, so these should be merged first. Do not make fixes
depend on feature.

- Mani

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2 0/3] QPIC v2 fixes for SDX75

Posted by Miquel Raynal 1 year, 1 month ago

>> Do you plan to respin this series? FYI, these are regressions, so
>> should go in
>> early as possible.
> Waiting for SPI NAND series patches [1] to be merged (raw nand change
> patch 2-5). On top of that will repost these patches.

When there are comments on a series, the entire series usually gets
discarded, so it is now out of my sight. If you want the spi bits to be
applied, it must make sense to have them alone, but you can send a new
version of the spi bits alone if you feel like the raw nand patches
aren't ready. But otherwise please fix the series and send a new
version.

Thanks,
Miquèl

Re: [PATCH v2 0/3] QPIC v2 fixes for SDX75

Posted by Md Sadre Alam 1 year, 1 month ago


On 12/24/2024 1:39 PM, Miquel Raynal wrote:
>>> Do you plan to respin this series? FYI, these are regressions, so
>>> should go in
>>> early as possible.
>> Waiting for SPI NAND series patches [1] to be merged (raw nand change
>> patch 2-5). On top of that will repost these patches.
> 
> When there are comments on a series, the entire series usually gets
> discarded, so it is now out of my sight. If you want the spi bits to be
> applied, it must make sense to have them alone, but you can send a new
> version of the spi bits alone if you feel like the raw nand patches
> aren't ready. But otherwise please fix the series and send a new
> version.
Sure Will create 2 different series one for raw nand along with SDX75 
bug fixes added and another series for SPI NAND support and repost.
> 
> Thanks,
> Miquèl

RE: [PATCH v2 0/3] QPIC v2 fixes for SDX75

Posted by Lakshmi Sowjanya D (QUIC) 1 year, 2 months ago


> -----Original Message-----
> From: Md Sadre Alam (QUIC) <quic_mdalam@quicinc.com>
> Sent: Friday, November 22, 2024 2:30 PM
> To: manivannan.sadhasivam@linaro.org; miquel.raynal@bootlin.com;
> richard@nod.at; vigneshr@ti.com; bbrezillon@kernel.org; linux-
> mtd@lists.infradead.org; linux-arm-msm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Sricharan Ramabadhran (QUIC) <quic_srichara@quicinc.com>;
> Varadarajan Narayanan (QUIC) <quic_varada@quicinc.com>; Md Sadre Alam
> (QUIC) <quic_mdalam@quicinc.com>; Naina Mehta (QUIC)
> <quic_nainmeht@quicinc.com>; Lakshmi Sowjanya D (QUIC)
> <quic_laksd@quicinc.com>
> Subject: [PATCH v2 0/3] QPIC v2 fixes for SDX75
> 
> v2:
>  * Updated commit message
>  * Added stable kernel tag
>  * Added Fixes tag
>  * Renamed the variable from offset_from_qpic to nandc_offset
>  * Set buf_count to 512 in the parameter page read
>  * Replaced the buf_count value of 512 with the len in bytes
> 
> v1:
>  * These patches will fix the following:
>  * 1) onfi param page read which was broken by exec_op() patch.
>  * 2) Fixed offset passed to BAM from QPIC base
> 
> Md Sadre Alam (3):
>   mtd: rawnand: qcom: Pass 18 bit offset from QPIC base address to BAM
>   mtd: rawnand: qcom: Fix onfi param page read
>   mtd: rawnand: qcom: Fix read len for onfi param page
> 
>  drivers/mtd/nand/raw/qcom_nandc.c | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
> 
> --

Tested-by: Lakshmi Sowjanya D <quic_laksd@quicinc.com>     # on SDX75

-- 
Regards
Lakshmi Sowjanya