[v4] Add jump table support for objtool on LoongArch

[PATCH v4 00/10] Add jump table support for objtool on LoongArch

Posted by Tiezhu Yang 1 year, 2 months ago

This series is based on 6.12-rc7, tested with the latest upstream
mainline Binutils, GCC and Clang, most of the patches are aim to
handle the special cases compiled with Clang on LoongArch.

v4:
  -- Avoid EM_LOONGARCH and R_LARCH_32_PCREL undeclared error
     for various compiling environments.

  -- Remove the check condition "dest_insn->type == INSN_NOP"
     for unreachable entry of rodata.

Tiezhu Yang (10):
  objtool: Handle various symbol types of rodata
  objtool: Handle special cases of dead end insn
  objtool: Handle different entry size of rodata
  objtool: Handle PC relative relocation type
  objtool: Handle unreachable entry of rodata
  objtool: Handle unsorted table offset of rodata
  objtool/LoongArch: Get each table size of rodata
  objtool/LoongArch: Add support for switch table
  objtool/LoongArch: Add support for goto table
  LoongArch: Enable jump table for objtool

 arch/loongarch/Kconfig                 |   3 +
 arch/loongarch/Makefile                |   4 +
 tools/objtool/arch/loongarch/special.c | 156 ++++++++++++++++++++++++-
 tools/objtool/check.c                  |  75 +++++++++++-
 tools/objtool/include/objtool/check.h  |   1 +
 5 files changed, 233 insertions(+), 6 deletions(-)

-- 
2.42.0

Re: [PATCH v4 00/10] Add jump table support for objtool on LoongArch

Posted by Huacai Chen 1 year, 2 months ago

Series applied, thanks.

Huacai

On Fri, Nov 22, 2024 at 12:50 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> This series is based on 6.12-rc7, tested with the latest upstream
> mainline Binutils, GCC and Clang, most of the patches are aim to
> handle the special cases compiled with Clang on LoongArch.
>
> v4:
>   -- Avoid EM_LOONGARCH and R_LARCH_32_PCREL undeclared error
>      for various compiling environments.
>
>   -- Remove the check condition "dest_insn->type == INSN_NOP"
>      for unreachable entry of rodata.
>
> Tiezhu Yang (10):
>   objtool: Handle various symbol types of rodata
>   objtool: Handle special cases of dead end insn
>   objtool: Handle different entry size of rodata
>   objtool: Handle PC relative relocation type
>   objtool: Handle unreachable entry of rodata
>   objtool: Handle unsorted table offset of rodata
>   objtool/LoongArch: Get each table size of rodata
>   objtool/LoongArch: Add support for switch table
>   objtool/LoongArch: Add support for goto table
>   LoongArch: Enable jump table for objtool
>
>  arch/loongarch/Kconfig                 |   3 +
>  arch/loongarch/Makefile                |   4 +
>  tools/objtool/arch/loongarch/special.c | 156 ++++++++++++++++++++++++-
>  tools/objtool/check.c                  |  75 +++++++++++-
>  tools/objtool/include/objtool/check.h  |   1 +
>  5 files changed, 233 insertions(+), 6 deletions(-)
>
> --
> 2.42.0
>

Re: [PATCH v4 00/10] Add jump table support for objtool on LoongArch

Posted by Josh Poimboeuf 1 year, 2 months ago

On Sun, Nov 24, 2024 at 01:33:43PM +0800, Huacai Chen wrote:
> Series applied, thanks.
> 
> Huacai

Please don't merge any objtool code without maintainer acks.

-- 
Josh

Re: [PATCH v4 00/10] Add jump table support for objtool on LoongArch

Posted by Huacai Chen 1 year, 2 months ago

Hi, Josh,

On Tue, Nov 26, 2024 at 3:29 PM Josh Poimboeuf <jpoimboe@kernel.org> wrote:
>
> On Sun, Nov 24, 2024 at 01:33:43PM +0800, Huacai Chen wrote:
> > Series applied, thanks.
> >
> > Huacai
>
> Please don't merge any objtool code without maintainer acks.
I'm sorry for that, I'll drop it first, and then wait for Tiezhu's new version.


Huacai
>
> --
> Josh