[PATCH] drm/msm/dpu: Add VBIF to DPU snapshot

Jessica Zhang posted 1 patch 1 year, 2 months ago
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH] drm/msm/dpu: Add VBIF to DPU snapshot
Posted by Jessica Zhang 1 year, 2 months ago
Add VBIF registers to the DPU snapshot to help with debugging.

Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index ca4847b2b73876c59dedff1e3ec4188ea70860a7..df90b080be5a1a07bea76bad4f282d80cc0e4397 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -1024,6 +1024,14 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
 		msm_disp_snapshot_add_block(disp_state, cat->cdm->len,
 					    dpu_kms->mmio + cat->cdm->base, cat->cdm->name);
 
+	for (i = 0; i < dpu_kms->catalog->vbif_count; i++) {
+		const struct dpu_vbif_cfg *vbif = &dpu_kms->catalog->vbif[i];
+
+		msm_disp_snapshot_add_block(disp_state, vbif->len,
+					    dpu_kms->vbif[vbif->id] + vbif->base,
+					    vbif->name);
+	}
+
 	pm_runtime_put_sync(&dpu_kms->pdev->dev);
 }
 

---
base-commit: 86313a9cd152330c634b25d826a281c6a002eb77
change-id: 20241122-vbif-snapshot-b6738fd73acf

Best regards,
-- 
Jessica Zhang <quic_jesszhan@quicinc.com>
Re: [PATCH] drm/msm/dpu: Add VBIF to DPU snapshot
Posted by Dmitry Baryshkov 1 year, 1 month ago
On Fri, 22 Nov 2024 15:09:10 -0800, Jessica Zhang wrote:
> Add VBIF registers to the DPU snapshot to help with debugging.
> 
> 

Applied, thanks!

[1/1] drm/msm/dpu: Add VBIF to DPU snapshot
      https://gitlab.freedesktop.org/lumag/msm/-/commit/1a40bb31fcf1

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Re: [PATCH] drm/msm/dpu: Add VBIF to DPU snapshot
Posted by Dmitry Baryshkov 1 year, 2 months ago
On Fri, Nov 22, 2024 at 03:09:10PM -0800, Jessica Zhang wrote:
> Add VBIF registers to the DPU snapshot to help with debugging.
> 
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry
Re: [PATCH] drm/msm/dpu: Add VBIF to DPU snapshot
Posted by Abhinav Kumar 1 year, 2 months ago

On 11/22/2024 3:09 PM, Jessica Zhang wrote:
> Add VBIF registers to the DPU snapshot to help with debugging.
> 
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>