ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY address

[PATCH v2] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY address

Posted by Nobuhiro Iwamatsu 1 year, 2 months ago

On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be
found and the network device does not work.

```
stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)
```

To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the
mdio bus. Also the PHY address connected to this board is 4. Therefore,
change to 4.

Cc: stable@vger.kernel.org # 6.3+
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 v2: Update commit message from 'ID' to 'address'.
     Drop Fixes tag, because that commit is not the cause.

 arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
index ce0d6514eeb571..e4794ccb8e413f 100644
--- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
+++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
@@ -66,8 +66,10 @@ &gmac1 {
 	mdio0 {
 		#address-cells = <1>;
 		#size-cells = <0>;
-		phy0: ethernet-phy@0 {
-			reg = <0>;
+		compatible = "snps,dwmac-mdio";
+
+		phy0: ethernet-phy@4 {
+			reg = <4>;
 			rxd0-skew-ps = <0>;
 			rxd1-skew-ps = <0>;
 			rxd2-skew-ps = <0>;
-- 
2.45.2

Re: [PATCH v2] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY address

Posted by Nobuhiro Iwamatsu 1 year ago

Hi Dinh,

Could you check and apply this patch?

Thanks,
  Nobuhiro

2024年11月21日(木) 16:13 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
>
> On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be
> found and the network device does not work.
>
> ```
> stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)
> ```
>
> To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the
> mdio bus. Also the PHY address connected to this board is 4. Therefore,
> change to 4.
>
> Cc: stable@vger.kernel.org # 6.3+
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  v2: Update commit message from 'ID' to 'address'.
>      Drop Fixes tag, because that commit is not the cause.
>
>  arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> index ce0d6514eeb571..e4794ccb8e413f 100644
> --- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> @@ -66,8 +66,10 @@ &gmac1 {
>         mdio0 {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> -               phy0: ethernet-phy@0 {
> -                       reg = <0>;
> +               compatible = "snps,dwmac-mdio";
> +
> +               phy0: ethernet-phy@4 {
> +                       reg = <4>;
>                         rxd0-skew-ps = <0>;
>                         rxd1-skew-ps = <0>;
>                         rxd2-skew-ps = <0>;
> --
> 2.45.2
>


-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 32247FBB40AD1FA6

Re: [PATCH v2] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY address

Posted by Nobuhiro Iwamatsu 5 months ago

ping?

2025年1月14日(火) 22:50 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
>
> Hi Dinh,
>
> Could you check and apply this patch?
>
> Thanks,
>   Nobuhiro
>
> 2024年11月21日(木) 16:13 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
> >
> > On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be
> > found and the network device does not work.
> >
> > ```
> > stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)
> > ```
> >
> > To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the
> > mdio bus. Also the PHY address connected to this board is 4. Therefore,
> > change to 4.
> >
> > Cc: stable@vger.kernel.org # 6.3+
> > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> > ---
> >  v2: Update commit message from 'ID' to 'address'.
> >      Drop Fixes tag, because that commit is not the cause.
> >
> >  arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> > index ce0d6514eeb571..e4794ccb8e413f 100644
> > --- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> > +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> > @@ -66,8 +66,10 @@ &gmac1 {
> >         mdio0 {
> >                 #address-cells = <1>;
> >                 #size-cells = <0>;
> > -               phy0: ethernet-phy@0 {
> > -                       reg = <0>;
> > +               compatible = "snps,dwmac-mdio";
> > +
> > +               phy0: ethernet-phy@4 {
> > +                       reg = <4>;
> >                         rxd0-skew-ps = <0>;
> >                         rxd1-skew-ps = <0>;
> >                         rxd2-skew-ps = <0>;
> > --
> > 2.45.2
> >
>
>
> --
> Nobuhiro Iwamatsu
>    iwamatsu at {nigauri.org / debian.org / kernel.org}
>    GPG ID: 32247FBB40AD1FA6



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 32247FBB40AD1FA6

Re: [PATCH v2] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY address

Posted by Dinh Nguyen 5 months ago


On 9/5/25 10:12, Nobuhiro Iwamatsu wrote:
> ping?
> 
> 2025年1月14日(火) 22:50 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
>>
>> Hi Dinh,
>>
>> Could you check and apply this patch?
>>
>> Thanks,
>>    Nobuhiro
>>

Sorry I missed this. I've applied it.

Dinh