From: Shiju Jose <shiju.jose@huawei.com>

Fix mismatch in 'region' field's name with kernel DRAM trace event.

Fixes: ea224ad58b37 ("rasdaemon: CXL: Extract, log and record region info from cxl_general_media and cxl_dram events")

Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
---
 ras-cxl-handler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ras-cxl-handler.c b/ras-cxl-handler.c
index 8733b2b..7d4fc9f 100644
--- a/ras-cxl-handler.c
+++ b/ras-cxl-handler.c
@@ -966,7 +966,7 @@ int ras_cxl_dram_event_handler(struct trace_seq *s,
 	if (trace_seq_printf(s, "hpa:0x%llx ", (unsigned long long)ev.hpa) <= 0)
 		return -1;
 
-	ev.region = tep_get_field_raw(s, event, "region", record, &len, 1);
+	ev.region = tep_get_field_raw(s, event, "region_name", record, &len, 1);
 	if (!ev.region)
 		return -1;
 	if (trace_seq_printf(s, "region:%s ", ev.region) <= 0)
-- 
2.43.0

On Wed, 20 Nov 2024 09:59:12 +0000
<shiju.jose@huawei.com> wrote:

> From: Shiju Jose <shiju.jose@huawei.com>
> 
> Fix mismatch in 'region' field's name with kernel DRAM trace event.
> 
> Fixes: ea224ad58b37 ("rasdaemon: CXL: Extract, log and record region info from cxl_general_media and cxl_dram events")
> 
No line break here (though this is rasdaemon so maybe kernel rules don't apply?)
> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  ras-cxl-handler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ras-cxl-handler.c b/ras-cxl-handler.c
> index 8733b2b..7d4fc9f 100644
> --- a/ras-cxl-handler.c
> +++ b/ras-cxl-handler.c
> @@ -966,7 +966,7 @@ int ras_cxl_dram_event_handler(struct trace_seq *s,
>  	if (trace_seq_printf(s, "hpa:0x%llx ", (unsigned long long)ev.hpa) <= 0)
>  		return -1;
>  
> -	ev.region = tep_get_field_raw(s, event, "region", record, &len, 1);
> +	ev.region = tep_get_field_raw(s, event, "region_name", record, &len, 1);
>  	if (!ev.region)
>  		return -1;
>  	if (trace_seq_printf(s, "region:%s ", ev.region) <= 0)

Hi Jonathan,

Thanks for reviewing. 
>-----Original Message-----
>From: Jonathan Cameron <jonathan.cameron@huawei.com>
>Sent: 21 November 2024 15:13
>To: Shiju Jose <shiju.jose@huawei.com>
>Cc: linux-edac@vger.kernel.org; linux-cxl@vger.kernel.org;
>mchehab@kernel.org; dave.jiang@intel.com; dan.j.williams@intel.com;
>alison.schofield@intel.com; nifan.cxl@gmail.com; vishal.l.verma@intel.com;
>ira.weiny@intel.com; dave@stgolabs.net; linux-kernel@vger.kernel.org;
>Linuxarm <linuxarm@huawei.com>; tanxiaofei <tanxiaofei@huawei.com>;
>Zengtao (B) <prime.zeng@hisilicon.com>
>Subject: Re: [PATCH 02/13] rasdaemon: cxl: Fix mismatch in region field's name
>with kernel DRAM trace event
>
>On Wed, 20 Nov 2024 09:59:12 +0000
><shiju.jose@huawei.com> wrote:
>
>> From: Shiju Jose <shiju.jose@huawei.com>
>>
>> Fix mismatch in 'region' field's name with kernel DRAM trace event.
>>
>> Fixes: ea224ad58b37 ("rasdaemon: CXL: Extract, log and record region
>> info from cxl_general_media and cxl_dram events")
>>
>No line break here (though this is rasdaemon so maybe kernel rules don't
>apply?)
Will fix.

>> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
>
>Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
>> ---
>>  ras-cxl-handler.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ras-cxl-handler.c b/ras-cxl-handler.c index
>> 8733b2b..7d4fc9f 100644
>> --- a/ras-cxl-handler.c
>> +++ b/ras-cxl-handler.c
>> @@ -966,7 +966,7 @@ int ras_cxl_dram_event_handler(struct trace_seq *s,
>>  	if (trace_seq_printf(s, "hpa:0x%llx ", (unsigned long long)ev.hpa) <= 0)
>>  		return -1;
>>
>> -	ev.region = tep_get_field_raw(s, event, "region", record, &len, 1);
>> +	ev.region = tep_get_field_raw(s, event, "region_name", record, &len,
>> +1);
>>  	if (!ev.region)
>>  		return -1;
>>  	if (trace_seq_printf(s, "region:%s ", ev.region) <= 0)
Thanks,
Shiju