[PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700

Jacky Chou posted 7 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700
Posted by Jacky Chou 1 year, 2 months ago
The AST2700 is the 7th generation SoC from Aspeed.
Add compatible support for AST2700 in yaml.

Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
 Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
index 9bcbacb6640d..fffe5c51daa9 100644
--- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
+++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
@@ -21,6 +21,7 @@ properties:
               - aspeed,ast2400-mac
               - aspeed,ast2500-mac
               - aspeed,ast2600-mac
+              - aspeed,ast2700-mac
           - const: faraday,ftgmac100
 
   reg:
@@ -33,7 +34,7 @@ properties:
     minItems: 1
     items:
       - description: MAC IP clock
-      - description: RMII RCLK gate for AST2500/2600
+      - description: RMII RCLK gate for AST2500/2600/2700
 
   clock-names:
     minItems: 1
-- 
2.25.1
Re: [PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700
Posted by Philipp Zabel 1 year, 2 months ago
On Mi, 2024-11-20 at 15:50 +0800, Jacky Chou wrote:
> The AST2700 is the 7th generation SoC from Aspeed.
> Add compatible support for AST2700 in yaml.
> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> index 9bcbacb6640d..fffe5c51daa9 100644
> --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> @@ -21,6 +21,7 @@ properties:
>                - aspeed,ast2400-mac
>                - aspeed,ast2500-mac
>                - aspeed,ast2600-mac
> +              - aspeed,ast2700-mac
>            - const: faraday,ftgmac100
>  
>    reg:
> @@ -33,7 +34,7 @@ properties:
>      minItems: 1
>      items:
>        - description: MAC IP clock
> -      - description: RMII RCLK gate for AST2500/2600
> +      - description: RMII RCLK gate for AST2500/2600/2700
>  
>    clock-names:
>      minItems: 1

Given patch 3, I would expect a resets property to be defined and
possibly added to the list of required properties for aspeed,ast2700-
mac.

regards
Philipp
Re: [PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700
Posted by Krzysztof Kozlowski 1 year, 2 months ago
On 25/11/2024 11:24, Philipp Zabel wrote:
> On Mi, 2024-11-20 at 15:50 +0800, Jacky Chou wrote:
>> The AST2700 is the 7th generation SoC from Aspeed.
>> Add compatible support for AST2700 in yaml.
>>
>> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>>  Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
>> index 9bcbacb6640d..fffe5c51daa9 100644
>> --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
>> +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
>> @@ -21,6 +21,7 @@ properties:
>>                - aspeed,ast2400-mac
>>                - aspeed,ast2500-mac
>>                - aspeed,ast2600-mac
>> +              - aspeed,ast2700-mac
>>            - const: faraday,ftgmac100
>>  
>>    reg:
>> @@ -33,7 +34,7 @@ properties:
>>      minItems: 1
>>      items:
>>        - description: MAC IP clock
>> -      - description: RMII RCLK gate for AST2500/2600
>> +      - description: RMII RCLK gate for AST2500/2600/2700
>>  
>>    clock-names:
>>      minItems: 1
> 
> Given patch 3, I would expect a resets property to be defined and
> possibly added to the list of required properties for aspeed,ast2700-
> mac.


Yeah, DTS was not tested at all.

Jacky, where is the DTS, so we can validate it? Please provide link in
cover letter.

Best regards,
Krzysztof