[v1] Add watchdog support for IPQ5424

[PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node

Posted by Manikanta Mylavarapu 1 year, 2 months ago

Add the watchdog node for IPQ5424 SoC.

Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq5424.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
index 5e219f900412..4ca1ef1c4dc7 100644
--- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
@@ -233,6 +233,13 @@ intc: interrupt-controller@f200000 {
 			msi-controller;
 		};
 
+		watchdog: watchdog@f410000 {
+			compatible = "qcom,apss-wdt-ipq5424", "qcom,kpss-wdt";
+			reg = <0 0x0f410000 0 0x1000>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
+			clocks = <&sleep_clk>;
+		};
+
 		timer@f420000 {
 			compatible = "arm,armv7-timer-mem";
 			reg = <0 0xf420000 0 0x1000>;
-- 
2.34.1

Re: [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node

Posted by Konrad Dybcio 1 year, 2 months ago

On 20.11.2024 6:52 AM, Manikanta Mylavarapu wrote:
> Add the watchdog node for IPQ5424 SoC.
> 
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node

Posted by Krzysztof Kozlowski 1 year, 2 months ago

On 20/11/2024 06:52, Manikanta Mylavarapu wrote:
> Add the watchdog node for IPQ5424 SoC.
> 
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5424.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> index 5e219f900412..4ca1ef1c4dc7 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> @@ -233,6 +233,13 @@ intc: interrupt-controller@f200000 {
>  			msi-controller;
>  		};
>  
> +		watchdog: watchdog@f410000 {
You do not use the label. Can be dropped.

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node

Posted by Manikanta Mylavarapu 1 year, 2 months ago


On 11/20/2024 1:10 PM, Krzysztof Kozlowski wrote:
> On 20/11/2024 06:52, Manikanta Mylavarapu wrote:
>> Add the watchdog node for IPQ5424 SoC.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/ipq5424.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
>> index 5e219f900412..4ca1ef1c4dc7 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
>> @@ -233,6 +233,13 @@ intc: interrupt-controller@f200000 {
>>  			msi-controller;
>>  		};
>>  
>> +		watchdog: watchdog@f410000 {
> You do not use the label. Can be dropped.
> 

Okay, sure. I will drop label.

Thanks & Regards,
Manikanta.