[PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev

Potin Lai posted 2 patches 1 year ago
[PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev
Posted by Potin Lai 1 year ago
Add ipmb-dev into trivial-devices to support IPMB device node.

Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index aa09dc51dab7..89dfac9b6a9e 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -149,6 +149,8 @@ properties:
           - injoinic,ip5209
             # Inspur Power System power supply unit version 1
           - inspur,ipsps1
+            # IPMB Device
+          - ipmb-dev
             # Intersil ISL29028 Ambient Light and Proximity Sensor
           - isil,isl29028
             # Intersil ISL29030 Ambient Light and Proximity Sensor

-- 
2.31.1
Re: [PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev
Posted by Conor Dooley 1 year ago
On Wed, Nov 20, 2024 at 11:28:07PM +0800, Potin Lai wrote:
> Add ipmb-dev into trivial-devices to support IPMB device node.

What is an "impb device"? You need a better description than this.

> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index aa09dc51dab7..89dfac9b6a9e 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -149,6 +149,8 @@ properties:
>            - injoinic,ip5209
>              # Inspur Power System power supply unit version 1
>            - inspur,ipsps1
> +            # IPMB Device
> +          - ipmb-dev
>              # Intersil ISL29028 Ambient Light and Proximity Sensor
>            - isil,isl29028
>              # Intersil ISL29030 Ambient Light and Proximity Sensor
> 
> -- 
> 2.31.1
> 
Re: [PATCH 2/2] dt-bindings: trivial-devices: add ipmb-dev
Posted by Krzysztof Kozlowski 1 year ago
On 20/11/2024 17:22, Conor Dooley wrote:
> On Wed, Nov 20, 2024 at 11:28:07PM +0800, Potin Lai wrote:
>> Add ipmb-dev into trivial-devices to support IPMB device node.
> 
> What is an "impb device"? You need a better description than this.
And provide users of these two. That's necessary for something that is
not even matching standard compatible format.

Best regards,
Krzysztof