[v4] binder: faster page installations

[PATCH v4 8/9] binder: propagate vm_insert_page() errors

Posted by Carlos Llamas 4 days, 5 hours ago

Instead of always overriding errors with -ENOMEM, propagate the specific
error code returned by vm_insert_page(). This allows for more accurate
error logs and handling.

Cc: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
 drivers/android/binder_alloc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
index f5dbaf1d7d65..aea35d475ee8 100644
--- a/drivers/android/binder_alloc.c
+++ b/drivers/android/binder_alloc.c
@@ -339,7 +339,6 @@ static int binder_install_single_page(struct binder_alloc *alloc,
 		__free_page(page);
 		pr_err("%d: %s failed to insert page at offset %lx with %d\n",
 		       alloc->pid, __func__, addr - alloc->vm_start, ret);
-		ret = -ENOMEM;
 		break;
 	}
 out:
-- 
2.47.0.338.g60cca15819-goog

Re: [PATCH v4 8/9] binder: propagate vm_insert_page() errors

Posted by Suren Baghdasaryan 1 day, 8 hours ago

On Tue, Nov 19, 2024 at 10:33 AM Carlos Llamas <cmllamas@google.com> wrote:
>
> Instead of always overriding errors with -ENOMEM, propagate the specific
> error code returned by vm_insert_page(). This allows for more accurate
> error logs and handling.
>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>

Reviewed-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  drivers/android/binder_alloc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index f5dbaf1d7d65..aea35d475ee8 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -339,7 +339,6 @@ static int binder_install_single_page(struct binder_alloc *alloc,
>                 __free_page(page);
>                 pr_err("%d: %s failed to insert page at offset %lx with %d\n",
>                        alloc->pid, __func__, addr - alloc->vm_start, ret);
> -               ret = -ENOMEM;
>                 break;
>         }
>  out:
> --
> 2.47.0.338.g60cca15819-goog
>