Add device tree support for QCS9075 Ride & Ride-r3 boards.
QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3
boards but without safety monitoring feature of SAfety-IsLand
subsystem.
Difference between ride and ride-r3 is the ethernet phy.
Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy.
Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
---
arch/arm64/boot/dts/qcom/Makefile | 2 ++
arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++
arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++
3 files changed, 26 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts
create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 5d9847119f2e..91c811aca2ca 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb
+dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb
+dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb
dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb
diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts
new file mode 100644
index 000000000000..a04c8d1fa258
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+/dts-v1/;
+
+#include "sa8775p-ride-r3.dts"
+
+/ {
+ model = "Qualcomm Technologies, Inc. QCS9075 Ride Rev3";
+ compatible = "qcom,qcs9075-ride-r3", "qcom,qcs9075", "qcom,sa8775p";
+};
diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride.dts
new file mode 100644
index 000000000000..9ffab74fb1a8
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/qcs9075-ride.dts
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+/dts-v1/;
+
+#include "sa8775p-ride.dts"
+
+/ {
+ model = "Qualcomm Technologies, Inc. QCS9075 Ride";
+ compatible = "qcom,qcs9075-ride", "qcom,qcs9075", "qcom,sa8775p";
+};
--
2.47.0On 19/11/2024 18:49, Wasim Nazir wrote: > Add device tree support for QCS9075 Ride & Ride-r3 boards. > QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > boards but without safety monitoring feature of SAfety-IsLand > subsystem. > > Difference between ride and ride-r3 is the ethernet phy. > Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 2 ++ > arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ > arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ > 3 files changed, 26 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 5d9847119f2e..91c811aca2ca 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > new file mode 100644 > index 000000000000..a04c8d1fa258 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > +/dts-v1/; > + > +#include "sa8775p-ride-r3.dts" No guys, you are making these things up. This is EXACTLY the same as qcs9100. NAK Best regards, Krzysztof
On Wed, Nov 20, 2024 at 05:44:11PM +0100, Krzysztof Kozlowski wrote: > On 19/11/2024 18:49, Wasim Nazir wrote: > > Add device tree support for QCS9075 Ride & Ride-r3 boards. > > QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > > boards but without safety monitoring feature of SAfety-IsLand > > subsystem. > > > > Difference between ride and ride-r3 is the ethernet phy. > > Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/Makefile | 2 ++ > > arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ > > arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ > > 3 files changed, 26 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > index 5d9847119f2e..91c811aca2ca 100644 > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > new file mode 100644 > > index 000000000000..a04c8d1fa258 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > @@ -0,0 +1,12 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > > + */ > > +/dts-v1/; > > + > > +#include "sa8775p-ride-r3.dts" > No guys, you are making these things up. This is EXACTLY the same as > qcs9100. 9100 & 9075 are different from “safe” perspective. They differ in changes related to thermal which will be added later in devicetree. > > NAK > > > > Best regards, > Krzysztof Thanks & Regards, Wasim
On 6.12.2024 12:04 PM, Wasim Nazir wrote: > On Wed, Nov 20, 2024 at 05:44:11PM +0100, Krzysztof Kozlowski wrote: >> On 19/11/2024 18:49, Wasim Nazir wrote: >>> Add device tree support for QCS9075 Ride & Ride-r3 boards. >>> QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 >>> boards but without safety monitoring feature of SAfety-IsLand >>> subsystem. >>> >>> Difference between ride and ride-r3 is the ethernet phy. >>> Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. >>> >>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 2 ++ >>> arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ >>> arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ >>> 3 files changed, 26 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index 5d9847119f2e..91c811aca2ca 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>> new file mode 100644 >>> index 000000000000..a04c8d1fa258 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>> @@ -0,0 +1,12 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> +/dts-v1/; >>> + >>> +#include "sa8775p-ride-r3.dts" >> No guys, you are making these things up. This is EXACTLY the same as >> qcs9100. > > 9100 & 9075 are different from “safe” perspective. They differ in > changes related to thermal which will be added later in devicetree. Since this can't be inferred from just looking at the changes, please make sure to add that to the commit message Konrad
On Fri, Dec 06, 2024 at 01:14:26PM +0100, Konrad Dybcio wrote: > On 6.12.2024 12:04 PM, Wasim Nazir wrote: > > On Wed, Nov 20, 2024 at 05:44:11PM +0100, Krzysztof Kozlowski wrote: > >> On 19/11/2024 18:49, Wasim Nazir wrote: > >>> Add device tree support for QCS9075 Ride & Ride-r3 boards. > >>> QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > >>> boards but without safety monitoring feature of SAfety-IsLand > >>> subsystem. > >>> > >>> Difference between ride and ride-r3 is the ethernet phy. > >>> Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > >>> > >>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > >>> --- > >>> arch/arm64/boot/dts/qcom/Makefile | 2 ++ > >>> arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ > >>> arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ > >>> 3 files changed, 26 insertions(+) > >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > >>> > >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > >>> index 5d9847119f2e..91c811aca2ca 100644 > >>> --- a/arch/arm64/boot/dts/qcom/Makefile > >>> +++ b/arch/arm64/boot/dts/qcom/Makefile > >>> @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > >>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> new file mode 100644 > >>> index 000000000000..a04c8d1fa258 > >>> --- /dev/null > >>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> @@ -0,0 +1,12 @@ > >>> +// SPDX-License-Identifier: BSD-3-Clause > >>> +/* > >>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > >>> + */ > >>> +/dts-v1/; > >>> + > >>> +#include "sa8775p-ride-r3.dts" > >> No guys, you are making these things up. This is EXACTLY the same as > >> qcs9100. > > > > 9100 & 9075 are different from “safe” perspective. They differ in > > changes related to thermal which will be added later in devicetree. > > Since this can't be inferred from just looking at the changes, please > make sure to add that to the commit message > Sure, will add more details in next patch series. > Konrad Thanks & Regards, Wasim
On 06/12/2024 13:14, Konrad Dybcio wrote: >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>>> new file mode 100644 >>>> index 000000000000..a04c8d1fa258 >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>>> @@ -0,0 +1,12 @@ >>>> +// SPDX-License-Identifier: BSD-3-Clause >>>> +/* >>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. >>>> + */ >>>> +/dts-v1/; >>>> + >>>> +#include "sa8775p-ride-r3.dts" >>> No guys, you are making these things up. This is EXACTLY the same as >>> qcs9100. >> >> 9100 & 9075 are different from “safe” perspective. They differ in >> changes related to thermal which will be added later in devicetree. > > Since this can't be inferred from just looking at the changes, please > make sure to add that to the commit message Any include of other DTS is clear sign something is odd here. Including multiple times without any added nodes is showing these are not real products/boards . Best regards, Krzysztof
On Fri, Dec 06, 2024 at 01:49:51PM +0100, Krzysztof Kozlowski wrote: > On 06/12/2024 13:14, Konrad Dybcio wrote: > >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>> new file mode 100644 > >>>> index 000000000000..a04c8d1fa258 > >>>> --- /dev/null > >>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>> @@ -0,0 +1,12 @@ > >>>> +// SPDX-License-Identifier: BSD-3-Clause > >>>> +/* > >>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > >>>> + */ > >>>> +/dts-v1/; > >>>> + > >>>> +#include "sa8775p-ride-r3.dts" > >>> No guys, you are making these things up. This is EXACTLY the same as > >>> qcs9100. > >> > >> 9100 & 9075 are different from “safe” perspective. They differ in > >> changes related to thermal which will be added later in devicetree. > > > > Since this can't be inferred from just looking at the changes, please > > make sure to add that to the commit message > > Any include of other DTS is clear sign something is odd here. Including > multiple times without any added nodes is showing these are not real > products/boards . We're adding DTS to reuse the common board changes, with plans to include the differences in upcoming patches. To provide more clarity, I will include patches in this series to highlight the differences between the 9100 and 9075 boards. > Best regards, > Krzysztof Thanks & Regards, Wasim
On 09/12/2024 19:58, Wasim Nazir wrote: > On Fri, Dec 06, 2024 at 01:49:51PM +0100, Krzysztof Kozlowski wrote: >> On 06/12/2024 13:14, Konrad Dybcio wrote: >>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>>>>> new file mode 100644 >>>>>> index 000000000000..a04c8d1fa258 >>>>>> --- /dev/null >>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>>>>> @@ -0,0 +1,12 @@ >>>>>> +// SPDX-License-Identifier: BSD-3-Clause >>>>>> +/* >>>>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. >>>>>> + */ >>>>>> +/dts-v1/; >>>>>> + >>>>>> +#include "sa8775p-ride-r3.dts" >>>>> No guys, you are making these things up. This is EXACTLY the same as >>>>> qcs9100. >>>> >>>> 9100 & 9075 are different from “safe” perspective. They differ in >>>> changes related to thermal which will be added later in devicetree. >>> >>> Since this can't be inferred from just looking at the changes, please >>> make sure to add that to the commit message >> >> Any include of other DTS is clear sign something is odd here. Including >> multiple times without any added nodes is showing these are not real >> products/boards . > > We're adding DTS to reuse the common board changes, with plans to > include the differences in upcoming patches. To provide more clarity, I > will include patches in this series to highlight the differences between > the 9100 and 9075 boards. Sure, still do not include DTS. Just like C files don't include C files. Best regards, Krzysztof
On Mon, Dec 09, 2024 at 08:30:07PM +0100, Krzysztof Kozlowski wrote: > On 09/12/2024 19:58, Wasim Nazir wrote: > > On Fri, Dec 06, 2024 at 01:49:51PM +0100, Krzysztof Kozlowski wrote: > >> On 06/12/2024 13:14, Konrad Dybcio wrote: > >>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>>>> new file mode 100644 > >>>>>> index 000000000000..a04c8d1fa258 > >>>>>> --- /dev/null > >>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>>>> @@ -0,0 +1,12 @@ > >>>>>> +// SPDX-License-Identifier: BSD-3-Clause > >>>>>> +/* > >>>>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > >>>>>> + */ > >>>>>> +/dts-v1/; > >>>>>> + > >>>>>> +#include "sa8775p-ride-r3.dts" > >>>>> No guys, you are making these things up. This is EXACTLY the same as > >>>>> qcs9100. > >>>> > >>>> 9100 & 9075 are different from “safe” perspective. They differ in > >>>> changes related to thermal which will be added later in devicetree. > >>> > >>> Since this can't be inferred from just looking at the changes, please > >>> make sure to add that to the commit message > >> > >> Any include of other DTS is clear sign something is odd here. Including > >> multiple times without any added nodes is showing these are not real > >> products/boards . > > > > We're adding DTS to reuse the common board changes, with plans to > > include the differences in upcoming patches. To provide more clarity, I > > will include patches in this series to highlight the differences between > > the 9100 and 9075 boards. > > Sure, still do not include DTS. Just like C files don't include C files. So, is the solution simple, rename .dts to .dtsi and include it from both .dts files? -- With best wishes Dmitry
On 10/12/2024 00:25, Dmitry Baryshkov wrote: >>>>>> 9100 & 9075 are different from “safe” perspective. They differ in >>>>>> changes related to thermal which will be added later in devicetree. >>>>> >>>>> Since this can't be inferred from just looking at the changes, please >>>>> make sure to add that to the commit message >>>> >>>> Any include of other DTS is clear sign something is odd here. Including >>>> multiple times without any added nodes is showing these are not real >>>> products/boards . >>> >>> We're adding DTS to reuse the common board changes, with plans to >>> include the differences in upcoming patches. To provide more clarity, I >>> will include patches in this series to highlight the differences between >>> the 9100 and 9075 boards. >> >> Sure, still do not include DTS. Just like C files don't include C files. > > So, is the solution simple, rename .dts to .dtsi and include it from > both .dts files? For example. This leads to more questions - what is common here? We do not create shared DTSI files just because someone wants, but to really note shared components or shared designs. Best regards, Krzysztof
On Tue, Dec 10, 2024 at 08:25:34AM +0100, Krzysztof Kozlowski wrote: > On 10/12/2024 00:25, Dmitry Baryshkov wrote: > >>>>>> 9100 & 9075 are different from “safe” perspective. They differ in > >>>>>> changes related to thermal which will be added later in devicetree. > >>>>> > >>>>> Since this can't be inferred from just looking at the changes, please > >>>>> make sure to add that to the commit message > >>>> > >>>> Any include of other DTS is clear sign something is odd here. Including > >>>> multiple times without any added nodes is showing these are not real > >>>> products/boards . > >>> > >>> We're adding DTS to reuse the common board changes, with plans to > >>> include the differences in upcoming patches. To provide more clarity, I > >>> will include patches in this series to highlight the differences between > >>> the 9100 and 9075 boards. > >> > >> Sure, still do not include DTS. Just like C files don't include C files. > > > > So, is the solution simple, rename .dts to .dtsi and include it from > > both .dts files? > > For example. This leads to more questions - what is common here? We do > not create shared DTSI files just because someone wants, but to really > note shared components or shared designs. > We can reuse the common dtsi for ride boards, i.e., sa8775p-ride.dtsi, and then add board-specific changes in the corresponding files. If this approach is acceptable, I can proceed with sending the next patch series. I hope this will help clarify things further. > Best regards, > Krzysztof Thanks & Regards, Wasim
On 10/12/2024 10:24, Wasim Nazir wrote: > On Tue, Dec 10, 2024 at 08:25:34AM +0100, Krzysztof Kozlowski wrote: >> On 10/12/2024 00:25, Dmitry Baryshkov wrote: >>>>>>>> 9100 & 9075 are different from “safe” perspective. They differ in >>>>>>>> changes related to thermal which will be added later in devicetree. >>>>>>> >>>>>>> Since this can't be inferred from just looking at the changes, please >>>>>>> make sure to add that to the commit message >>>>>> >>>>>> Any include of other DTS is clear sign something is odd here. Including >>>>>> multiple times without any added nodes is showing these are not real >>>>>> products/boards . >>>>> >>>>> We're adding DTS to reuse the common board changes, with plans to >>>>> include the differences in upcoming patches. To provide more clarity, I >>>>> will include patches in this series to highlight the differences between >>>>> the 9100 and 9075 boards. >>>> >>>> Sure, still do not include DTS. Just like C files don't include C files. >>> >>> So, is the solution simple, rename .dts to .dtsi and include it from >>> both .dts files? >> >> For example. This leads to more questions - what is common here? We do >> not create shared DTSI files just because someone wants, but to really >> note shared components or shared designs. >> > > We can reuse the common dtsi for ride boards, i.e., sa8775p-ride.dtsi, > and then add board-specific changes in the corresponding files. So you will create shared DTSI because "someone wants"? Did you read the question above and valid reasons/answers to it? > > If this approach is acceptable, I can proceed with sending the > next patch series. I hope this will help clarify things further. Best regards, Krzysztof
On Tue, Dec 10, 2024 at 12:50:51PM +0100, Krzysztof Kozlowski wrote: > On 10/12/2024 10:24, Wasim Nazir wrote: > > On Tue, Dec 10, 2024 at 08:25:34AM +0100, Krzysztof Kozlowski wrote: > >> On 10/12/2024 00:25, Dmitry Baryshkov wrote: > >>>>>>>> 9100 & 9075 are different from “safe” perspective. They differ in > >>>>>>>> changes related to thermal which will be added later in devicetree. > >>>>>>> > >>>>>>> Since this can't be inferred from just looking at the changes, please > >>>>>>> make sure to add that to the commit message > >>>>>> > >>>>>> Any include of other DTS is clear sign something is odd here. Including > >>>>>> multiple times without any added nodes is showing these are not real > >>>>>> products/boards . > >>>>> > >>>>> We're adding DTS to reuse the common board changes, with plans to > >>>>> include the differences in upcoming patches. To provide more clarity, I > >>>>> will include patches in this series to highlight the differences between > >>>>> the 9100 and 9075 boards. > >>>> > >>>> Sure, still do not include DTS. Just like C files don't include C files. > >>> > >>> So, is the solution simple, rename .dts to .dtsi and include it from > >>> both .dts files? > >> > >> For example. This leads to more questions - what is common here? We do > >> not create shared DTSI files just because someone wants, but to really > >> note shared components or shared designs. > >> > > > > We can reuse the common dtsi for ride boards, i.e., sa8775p-ride.dtsi, > > and then add board-specific changes in the corresponding files. > > > So you will create shared DTSI because "someone wants"? Did you read the > question above and valid reasons/answers to it? > Sorry, if I couldn't able to answer your question. We will not be creating any new DTSI files. Since QCS9075 is derived from SA8775P, we will be reusing the existing common DTSI files for the ride boards of the SA8775P and its derivative SoCs. Here is the change reference for common ride dtsi: https://lore.kernel.org/all/20240627114212.25400-3-brgl@bgdev.pl/ Please let me know if I missed anything. > > > > > If this approach is acceptable, I can proceed with sending the > > next patch series. I hope this will help clarify things further. > > Best regards, > Krzysztof Thanks & Regards, Wasim
On Tue, Nov 19, 2024 at 11:19:54PM +0530, Wasim Nazir wrote: > Add device tree support for QCS9075 Ride & Ride-r3 boards. > QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > boards but without safety monitoring feature of SAfety-IsLand > subsystem. > > Difference between ride and ride-r3 is the ethernet phy. > Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > --- Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> -- With best wishes Dmitry
© 2016 - 2026 Red Hat, Inc.