Am 19.11.24 um 18:17 schrieb Mario Limonciello:
> When a driver has called platform_profile_notify() both the legacy sysfs
> interface and the class device should be notified as userspace may listen
> to either.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v7:
> * Use class_for_each_device
> ---
> drivers/acpi/platform_profile.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index ca997f4e9a5cb..e88b355a72112 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -402,6 +402,10 @@ void platform_profile_notify(struct platform_profile_handler *pprof)
> {
> if (!cur_profile)
> return;
> + scoped_cond_guard(mutex_intr, return, &profile_lock) {
> + class_for_each_device(&platform_profile_class, NULL, NULL,
> + _notify_class_profile);
I think that using class_for_each_device() is a bit overblown here. He only want to notify a single platform profile,
so using class_for_each_device() is a bit too much. Using _notify_class_profile() is enough.
With that being fixed:
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
> + }
> sysfs_notify(acpi_kobj, NULL, "platform_profile");
> }
> EXPORT_SYMBOL_GPL(platform_profile_notify);