[v7] Add support for binding ACPI platform profile to multiple drivers

[PATCH v7 11/22] ACPI: platform_profile: Add name attribute to class interface

Posted by Mario Limonciello 4 days, 5 hours ago

The name attribute shows the name of the associated platform profile
handler.

Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v7:
 * Drop locking
---
 drivers/acpi/platform_profile.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index 3524a2b4618ed..a9d7ec3c85844 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -25,8 +25,32 @@ static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST);
 
 static DEFINE_IDA(platform_profile_ida);
 
+/**
+ * name_show - Show the name of the profile handler
+ * @dev: The device
+ * @attr: The attribute
+ * @buf: The buffer to write to
+ * Return: The number of bytes written
+ */
+static ssize_t name_show(struct device *dev,
+			 struct device_attribute *attr,
+			 char *buf)
+{
+	struct platform_profile_handler *handler = dev_get_drvdata(dev);
+
+	return sysfs_emit(buf, "%s\n", handler->name);
+}
+
+static DEVICE_ATTR_RO(name);
+static struct attribute *profile_attrs[] = {
+	&dev_attr_name.attr,
+	NULL
+};
+ATTRIBUTE_GROUPS(profile);
+
 static const struct class platform_profile_class = {
 	.name = "platform-profile",
+	.dev_groups = profile_groups,
 };
 
 static ssize_t platform_profile_choices_show(struct device *dev,
-- 
2.43.0

Re: [PATCH v7 11/22] ACPI: platform_profile: Add name attribute to class interface

Posted by Armin Wolf 2 days ago

Am 19.11.24 um 18:17 schrieb Mario Limonciello:

> The name attribute shows the name of the associated platform profile
> handler.
>
> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v7:
>   * Drop locking
> ---
>   drivers/acpi/platform_profile.c | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index 3524a2b4618ed..a9d7ec3c85844 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -25,8 +25,32 @@ static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST);
>
>   static DEFINE_IDA(platform_profile_ida);
>
> +/**
> + * name_show - Show the name of the profile handler
> + * @dev: The device
> + * @attr: The attribute
> + * @buf: The buffer to write to
> + * Return: The number of bytes written
> + */
> +static ssize_t name_show(struct device *dev,
> +			 struct device_attribute *attr,
> +			 char *buf)
> +{
> +	struct platform_profile_handler *handler = dev_get_drvdata(dev);
> +
> +	return sysfs_emit(buf, "%s\n", handler->name);
> +}
> +
> +static DEVICE_ATTR_RO(name);

Can you move DEVICE_ATTR_RO() right below name_show() and leave a blank line here? With that being fixed:

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

> +static struct attribute *profile_attrs[] = {
> +	&dev_attr_name.attr,
> +	NULL
> +};
> +ATTRIBUTE_GROUPS(profile);
> +
>   static const struct class platform_profile_class = {
>   	.name = "platform-profile",
> +	.dev_groups = profile_groups,
>   };
>
>   static ssize_t platform_profile_choices_show(struct device *dev,

Re: [PATCH v7 11/22] ACPI: platform_profile: Add name attribute to class interface

Posted by Ilpo Järvinen 3 days, 8 hours ago

On Tue, 19 Nov 2024, Mario Limonciello wrote:

> The name attribute shows the name of the associated platform profile
> handler.
> 
> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v7:
>  * Drop locking
> ---
>  drivers/acpi/platform_profile.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index 3524a2b4618ed..a9d7ec3c85844 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -25,8 +25,32 @@ static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST);
>  
>  static DEFINE_IDA(platform_profile_ida);
>  
> +/**
> + * name_show - Show the name of the profile handler
> + * @dev: The device
> + * @attr: The attribute
> + * @buf: The buffer to write to

Add an empty line here after args.

> + * Return: The number of bytes written
> + */
> +static ssize_t name_show(struct device *dev,
> +			 struct device_attribute *attr,
> +			 char *buf)

This fits to less lines.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
 i.

> +{
> +	struct platform_profile_handler *handler = dev_get_drvdata(dev);
> +
> +	return sysfs_emit(buf, "%s\n", handler->name);
> +}
> +
> +static DEVICE_ATTR_RO(name);
> +static struct attribute *profile_attrs[] = {
> +	&dev_attr_name.attr,
> +	NULL
> +};
> +ATTRIBUTE_GROUPS(profile);
> +
>  static const struct class platform_profile_class = {
>  	.name = "platform-profile",
> +	.dev_groups = profile_groups,
>  };
>  
>  static ssize_t platform_profile_choices_show(struct device *dev,
>