[PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add watchdog node

Xin Liu posted 3 patches 4 days, 5 hours ago
[PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add watchdog node
Posted by Xin Liu 4 days, 5 hours ago
Add the watchdog node for QCS8300 SoC.

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
index 2c35f96c3f28..13321b1a8af6 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
@@ -1122,6 +1122,12 @@ intc: interrupt-controller@17a00000 {
 			redistributor-stride = <0x0 0x20000>;
 		};
 
+		watchdog: watchdog@17c10000 {
+			compatible = "qcom,apss-wdt-qcs8300", "qcom,kpss-wdt";
+			reg = <0x0 0x17c10000 0x0 0x1000>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		memtimer: timer@17c20000 {
 			compatible = "arm,armv7-timer-mem";
 			reg = <0x0 0x17c20000 0x0 0x1000>;
-- 
2.34.1
Re: [PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add watchdog node
Posted by Krzysztof Kozlowski 2 days, 22 hours ago
On 19/11/2024 11:23, Xin Liu wrote:
> Add the watchdog node for QCS8300 SoC.
> 
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> ---

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

>  arch/arm64/boot/dts/qcom/qcs8300.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.
Best regards,
Krzysztof
Re: [PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add watchdog node
Posted by Xin Liu 1 day, 7 hours ago

在 2024/11/21 1:00, Krzysztof Kozlowski 写道:
> On 19/11/2024 11:23, Xin Liu wrote:
>> Add the watchdog node for QCS8300 SoC.
>>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>> ---
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
Thank you for your comments. In my cover letter:
PATCH 2/3:Drop the Reviewed-by tag that received by v1. Assign a label
to the wachdog node.

I have made modifications to the code. Should the reviewed by tag be 
removed in this situation.
>>   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.
> Best regards,
> Krzysztof