mm: correct typo in MMAP_STATE() macro

[PATCH] mm: correct typo in MMAP_STATE() macro

Posted by Lorenzo Stoakes 1 year, 2 months ago

We mistakenly refer to len rather than len_ here. The only existing caller
passes len to the len_ parameter so this has no impact on the code, but it
is obviously incorrect to do this, so fix it.

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 mm/vma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vma.c b/mm/vma.c
index 8a454a7bbc80..8e31b7e25aeb 100644
--- a/mm/vma.c
+++ b/mm/vma.c
@@ -35,7 +35,7 @@ struct mmap_state {
 		.mm = mm_,						\
 		.vmi = vmi_,						\
 		.addr = addr_,						\
-		.end = (addr_) + len,					\
+		.end = (addr_) + (len_),				\
 		.pgoff = pgoff_,					\
 		.pglen = PHYS_PFN(len_),				\
 		.flags = flags_,					\
-- 
2.47.0

Re: [PATCH] mm: correct typo in MMAP_STATE() macro

Posted by Wei Yang 1 year, 2 months ago

On Mon, Nov 18, 2024 at 05:54:14PM +0000, Lorenzo Stoakes wrote:
>We mistakenly refer to len rather than len_ here. The only existing caller
>passes len to the len_ parameter so this has no impact on the code, but it
>is obviously incorrect to do this, so fix it.
>
>Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Reviewed-by: Wei Yang <richard.weiyang@gmail.com>

-- 
Wei Yang
Help you, Help me

Re: [PATCH] mm: correct typo in MMAP_STATE() macro

Posted by Liam R. Howlett 1 year, 2 months ago

* Lorenzo Stoakes <lorenzo.stoakes@oracle.com> [241118 12:54]:
> We mistakenly refer to len rather than len_ here. The only existing caller
> passes len to the len_ parameter so this has no impact on the code, but it
> is obviously incorrect to do this, so fix it.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>

> ---
>  mm/vma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vma.c b/mm/vma.c
> index 8a454a7bbc80..8e31b7e25aeb 100644
> --- a/mm/vma.c
> +++ b/mm/vma.c
> @@ -35,7 +35,7 @@ struct mmap_state {
>  		.mm = mm_,						\
>  		.vmi = vmi_,						\
>  		.addr = addr_,						\
> -		.end = (addr_) + len,					\
> +		.end = (addr_) + (len_),				\
>  		.pgoff = pgoff_,					\
>  		.pglen = PHYS_PFN(len_),				\
>  		.flags = flags_,					\
> -- 
> 2.47.0
>