virtio: remove the duplicate might_sleep()

[PATCH] virtio: remove the duplicate might_sleep()

Posted by xiaowuding_jaguarmicro 1 year, 2 months ago

From: Xiaowu Ding <xiaowu.ding@jaguarmicro.com>

The virtio_add_status function have done might_sleep(),so we can remove
the duplicate calls.

Signed-off-by: Xiaowu Ding <xiaowu.ding@jaguarmicro.com>
---
 drivers/virtio/virtio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index b9095751e..8352dfc1a 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -205,8 +205,6 @@ static int virtio_features_ok(struct virtio_device *dev)
 {
 	unsigned int status;
 
-	might_sleep();
-
 	if (virtio_check_mem_acc_cb(dev)) {
 		if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1)) {
 			dev_warn(&dev->dev,
-- 
2.27.0

Re: [PATCH] virtio: remove the duplicate might_sleep()

Posted by Xuan Zhuo 1 year, 2 months ago

On Mon, 18 Nov 2024 20:40:56 +0800, "xiaowuding_jaguarmicro" <xiaowu.ding@jaguarmicro.com> wrote:
> From: Xiaowu Ding <xiaowu.ding@jaguarmicro.com>
>
> The virtio_add_status function have done might_sleep(),so we can remove
> the duplicate calls.


Is there any problem here? If not, I think we can keep it.

Thanks.

>
> Signed-off-by: Xiaowu Ding <xiaowu.ding@jaguarmicro.com>
> ---
>  drivers/virtio/virtio.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index b9095751e..8352dfc1a 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -205,8 +205,6 @@ static int virtio_features_ok(struct virtio_device *dev)
>  {
>  	unsigned int status;
>
> -	might_sleep();
> -
>  	if (virtio_check_mem_acc_cb(dev)) {
>  		if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1)) {
>  			dev_warn(&dev->dev,
> --
> 2.27.0
>