Rename the main fastrpc source file to accomodate new files to be
compiled in the same kernel object.
Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
---
drivers/misc/fastrpc/Makefile | 1 +
drivers/misc/fastrpc/{fastrpc.c => fastrpc_main.c} | 0
2 files changed, 1 insertion(+)
rename drivers/misc/fastrpc/{fastrpc.c => fastrpc_main.c} (100%)
diff --git a/drivers/misc/fastrpc/Makefile b/drivers/misc/fastrpc/Makefile
index 77fd2b763b6b..020d30789a80 100644
--- a/drivers/misc/fastrpc/Makefile
+++ b/drivers/misc/fastrpc/Makefile
@@ -1,2 +1,3 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_QCOM_FASTRPC) += fastrpc.o
+fastrpc-objs := fastrpc_main.o
\ No newline at end of file
diff --git a/drivers/misc/fastrpc/fastrpc.c b/drivers/misc/fastrpc/fastrpc_main.c
similarity index 100%
rename from drivers/misc/fastrpc/fastrpc.c
rename to drivers/misc/fastrpc/fastrpc_main.c
--
2.34.1
On Mon, Nov 18, 2024 at 02:10:44PM +0530, Ekansh Gupta wrote:
> Rename the main fastrpc source file to accomodate new files to be
> compiled in the same kernel object.
>
> Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
> ---
> drivers/misc/fastrpc/Makefile | 1 +
> drivers/misc/fastrpc/{fastrpc.c => fastrpc_main.c} | 0
> 2 files changed, 1 insertion(+)
> rename drivers/misc/fastrpc/{fastrpc.c => fastrpc_main.c} (100%)
>
> diff --git a/drivers/misc/fastrpc/Makefile b/drivers/misc/fastrpc/Makefile
> index 77fd2b763b6b..020d30789a80 100644
> --- a/drivers/misc/fastrpc/Makefile
> +++ b/drivers/misc/fastrpc/Makefile
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0
> obj-$(CONFIG_QCOM_FASTRPC) += fastrpc.o
> +fastrpc-objs := fastrpc_main.o
> \ No newline at end of file
> diff --git a/drivers/misc/fastrpc/fastrpc.c b/drivers/misc/fastrpc/fastrpc_main.c
> similarity index 100%
> rename from drivers/misc/fastrpc/fastrpc.c
> rename to drivers/misc/fastrpc/fastrpc_main.c
Why not just "main.c"? You are in your own subdir, no need for the
fastrpc_* prefix anymore, right?
thanks,
greg "naming is hard" k-h
On 11/18/2024 7:28 PM, Greg KH wrote:
> On Mon, Nov 18, 2024 at 02:10:44PM +0530, Ekansh Gupta wrote:
>> Rename the main fastrpc source file to accomodate new files to be
>> compiled in the same kernel object.
>>
>> Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
>> ---
>> drivers/misc/fastrpc/Makefile | 1 +
>> drivers/misc/fastrpc/{fastrpc.c => fastrpc_main.c} | 0
>> 2 files changed, 1 insertion(+)
>> rename drivers/misc/fastrpc/{fastrpc.c => fastrpc_main.c} (100%)
>>
>> diff --git a/drivers/misc/fastrpc/Makefile b/drivers/misc/fastrpc/Makefile
>> index 77fd2b763b6b..020d30789a80 100644
>> --- a/drivers/misc/fastrpc/Makefile
>> +++ b/drivers/misc/fastrpc/Makefile
>> @@ -1,2 +1,3 @@
>> # SPDX-License-Identifier: GPL-2.0
>> obj-$(CONFIG_QCOM_FASTRPC) += fastrpc.o
>> +fastrpc-objs := fastrpc_main.o
>> \ No newline at end of file
>> diff --git a/drivers/misc/fastrpc/fastrpc.c b/drivers/misc/fastrpc/fastrpc_main.c
>> similarity index 100%
>> rename from drivers/misc/fastrpc/fastrpc.c
>> rename to drivers/misc/fastrpc/fastrpc_main.c
> Why not just "main.c"? You are in your own subdir, no need for the
> fastrpc_* prefix anymore, right?
Ack. I will update the names in next patchset. Thanks.
--ekansh
> thanks,
>
> greg "naming is hard" k-h
© 2016 - 2026 Red Hat, Inc.