treewide: don't include 'pm_wakeup.h' directly

[PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly

Posted by Wolfram Sang 3 days, 8 hours ago

The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
index 66d44a404ad0..559972a00fdf 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
@@ -23,7 +23,6 @@
 #include <linux/cpu_pm.h>
 #include <linux/coresight.h>
 #include <linux/coresight-pmu.h>
-#include <linux/pm_wakeup.h>
 #include <linux/amba/bus.h>
 #include <linux/seq_file.h>
 #include <linux/uaccess.h>
-- 
2.39.2

Re: [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly

Posted by Suzuki K Poulose 3 days, 5 hours ago

On 18/11/2024 07:29, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>   drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> index 66d44a404ad0..559972a00fdf 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> @@ -23,7 +23,6 @@
>   #include <linux/cpu_pm.h>
>   #include <linux/coresight.h>
>   #include <linux/coresight-pmu.h>
> -#include <linux/pm_wakeup.h>
>   #include <linux/amba/bus.h>
>   #include <linux/seq_file.h>
>   #include <linux/uaccess.h>

If you plan to take this as a collection outside of CoreSight tree,

Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Otherwise, I can pick this up.


Suzuki

Re: [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly

Posted by Wolfram Sang 2 days, 20 hours ago

> If you plan to take this as a collection outside of CoreSight tree,
> 
> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> 
> Otherwise, I can pick this up.

As stated in the cover letter, please pick it up. There are no
dependencies.