[PATCH 12/15] platform/x86: quickstart: don't include 'pm_wakeup.h' directly

Wolfram Sang posted 15 patches 1 year, 2 months ago
[PATCH 12/15] platform/x86: quickstart: don't include 'pm_wakeup.h' directly
Posted by Wolfram Sang 1 year, 2 months ago
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/platform/x86/quickstart.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/quickstart.c b/drivers/platform/x86/quickstart.c
index 8d540a1c8602..c332c7cdaff5 100644
--- a/drivers/platform/x86/quickstart.c
+++ b/drivers/platform/x86/quickstart.c
@@ -20,7 +20,6 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/platform_device.h>
-#include <linux/pm_wakeup.h>
 #include <linux/printk.h>
 #include <linux/slab.h>
 #include <linux/sysfs.h>
-- 
2.39.2
Re: [PATCH 12/15] platform/x86: quickstart: don't include 'pm_wakeup.h' directly
Posted by Ilpo Järvinen 1 year, 2 months ago
On Mon, 18 Nov 2024, Wolfram Sang wrote:

> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/platform/x86/quickstart.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/quickstart.c b/drivers/platform/x86/quickstart.c
> index 8d540a1c8602..c332c7cdaff5 100644
> --- a/drivers/platform/x86/quickstart.c
> +++ b/drivers/platform/x86/quickstart.c
> @@ -20,7 +20,6 @@
>  #include <linux/module.h>
>  #include <linux/mutex.h>
>  #include <linux/platform_device.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/printk.h>
>  #include <linux/slab.h>
>  #include <linux/sysfs.h>

Thanks for the patch. I've applied it to the review-ilpo-next branch in 
the pdx86 repo.

-- 
 i.