[PATCH 11/15] PCI: don't include 'pm_wakeup.h' directly

Wolfram Sang posted 15 patches 1 year, 2 months ago
[PATCH 11/15] PCI: don't include 'pm_wakeup.h' directly
Posted by Wolfram Sang 1 year, 2 months ago
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/pci/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 225a6cd2e9ca..3b1939c9cf46 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -23,7 +23,6 @@
 #include <linux/string.h>
 #include <linux/log2.h>
 #include <linux/logic_pio.h>
-#include <linux/pm_wakeup.h>
 #include <linux/device.h>
 #include <linux/pm_runtime.h>
 #include <linux/pci_hotplug.h>
-- 
2.39.2
Re: [PATCH 11/15] PCI: don't include 'pm_wakeup.h' directly
Posted by Krzysztof Wilczyński 1 year, 1 month ago
Hello,

> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.

Applied to misc, thank you!

[01/01] PCI: Don't include 'pm_wakeup.h' directly
        https://git.kernel.org/pci/pci/c/cd3e4149e2f6

	Krzysztof
Re: [PATCH 11/15] PCI: don't include 'pm_wakeup.h' directly
Posted by Bjorn Helgaas 1 year, 2 months ago
On Mon, Nov 18, 2024 at 08:29:10AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

I plan to pick this up for v6.14 as soon as the v6.13 merge window
closes.

> ---
>  drivers/pci/pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 225a6cd2e9ca..3b1939c9cf46 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -23,7 +23,6 @@
>  #include <linux/string.h>
>  #include <linux/log2.h>
>  #include <linux/logic_pio.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/pci_hotplug.h>
> -- 
> 2.39.2
>