[PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray

Tamir Duberstein posted 2 patches 2 days, 23 hours ago
There is a newer version of this series
rust/bindings/bindings_helper.h |   6 +
rust/helpers/helpers.c          |   1 +
rust/helpers/xarray.c           |  28 +++++
rust/kernel/alloc.rs            |   5 +
rust/kernel/alloc/kbox.rs       |  38 +++---
rust/kernel/lib.rs              |   1 +
rust/kernel/sync/arc.rs         |  21 ++--
rust/kernel/types.rs            |  46 ++++---
rust/kernel/xarray.rs           | 259 ++++++++++++++++++++++++++++++++++++++++
9 files changed, 363 insertions(+), 42 deletions(-)
[PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray
Posted by Tamir Duberstein 2 days, 23 hours ago
This is a reimagining relative to earlier versions[0] by Asahi Lina and
Maíra Canal.

It is needed to support rust-binder, though this version only provides
enough machinery to support rnull.

Link: https://lore.kernel.org/rust-for-linux/20240309235927.168915-2-mcanal@igalia.com/ [0]
---
Tamir Duberstein (2):
      rust: types: add `ForeignOwnable::PointedTo`
      rust: xarray: Add an abstraction for XArray

 rust/bindings/bindings_helper.h |   6 +
 rust/helpers/helpers.c          |   1 +
 rust/helpers/xarray.c           |  28 +++++
 rust/kernel/alloc.rs            |   5 +
 rust/kernel/alloc/kbox.rs       |  38 +++---
 rust/kernel/lib.rs              |   1 +
 rust/kernel/sync/arc.rs         |  21 ++--
 rust/kernel/types.rs            |  46 ++++---
 rust/kernel/xarray.rs           | 259 ++++++++++++++++++++++++++++++++++++++++
 9 files changed, 363 insertions(+), 42 deletions(-)
---
base-commit: b2603f8ac8217bc59f5c7f248ac248423b9b99cb
change-id: 20241020-rust-xarray-bindings-bef514142968
prerequisite-change-id: 20241030-borrow-mut-75f181feef4c:v5
prerequisite-patch-id: f801fb31bb4f202b3327f5fdb50d3018e25347d1
prerequisite-patch-id: b57aa4f44b238d4cb80f00276a188d9ba0c743cc
prerequisite-patch-id: 2387ec5af1cc03614d3dff5a95cefcd243befd65
prerequisite-patch-id: 8de2f688833d4d16eece062c5b6937a95a6a0e8b
prerequisite-patch-id: 7f845443f373f975a888f01c3761fe8aa04b8a3c
prerequisite-patch-id: 5a9856c7363b33f0adfe8658e076b35abf960d23

Best regards,
-- 
Tamir Duberstein <tamird@gmail.com>

Re: [PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray
Posted by Miguel Ojeda 2 days, 23 hours ago
On Mon, Nov 18, 2024 at 5:33 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> This is a reimagining relative to earlier versions[0] by Asahi Lina and
> Maíra Canal.

Maíra's latest version has both of them listed as co-authors in the
main patch -- how close is this to that version? (I see some bits that
look fairly similar)

Thanks!

Cheers,
Miguel
Re: [PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray
Posted by Tamir Duberstein 2 days, 22 hours ago
On Mon, Nov 18, 2024 at 11:52 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Mon, Nov 18, 2024 at 5:33 PM Tamir Duberstein <tamird@gmail.com> wrote:
> >
> > This is a reimagining relative to earlier versions[0] by Asahi Lina and
> > Maíra Canal.
>
> Maíra's latest version has both of them listed as co-authors in the
> main patch -- how close is this to that version? (I see some bits that
> look fairly similar)
>
> Thanks!
>
> Cheers,
> Miguel

It's fairly different, and I discussed with both of them - we agreed
that Co-developed-by would not be appropriate.

Thanks!
Tamir
Re: [PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray
Posted by Maíra Canal 2 days, 4 hours ago
Hi Tamir & Miguel,

On 18/11/24 14:02, Tamir Duberstein wrote:
> On Mon, Nov 18, 2024 at 11:52 AM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
>>
>> On Mon, Nov 18, 2024 at 5:33 PM Tamir Duberstein <tamird@gmail.com> wrote:
>>>
>>> This is a reimagining relative to earlier versions[0] by Asahi Lina and
>>> Maíra Canal.
>>
>> Maíra's latest version has both of them listed as co-authors in the
>> main patch -- how close is this to that version? (I see some bits that
>> look fairly similar)
>>
>> Thanks!
>>
>> Cheers,
>> Miguel
> 
> It's fairly different, and I discussed with both of them - we agreed
> that Co-developed-by would not be appropriate.

I still agree that a Co-developed-by isn't appropriate, but I believe
that it would be fair to mention me and Lina on the commit message.

Best Regards,
- Maíra

> 
> Thanks!
> Tamir

Re: [PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray
Posted by Asahi Lina 2 days, 3 hours ago

On 11/19/24 8:11 PM, Maíra Canal wrote:
> Hi Tamir & Miguel,
> 
> On 18/11/24 14:02, Tamir Duberstein wrote:
>> On Mon, Nov 18, 2024 at 11:52 AM Miguel Ojeda
>> <miguel.ojeda.sandonis@gmail.com> wrote:
>>>
>>> On Mon, Nov 18, 2024 at 5:33 PM Tamir Duberstein <tamird@gmail.com>
>>> wrote:
>>>>
>>>> This is a reimagining relative to earlier versions[0] by Asahi Lina and
>>>> Maíra Canal.
>>>
>>> Maíra's latest version has both of them listed as co-authors in the
>>> main patch -- how close is this to that version? (I see some bits that
>>> look fairly similar)
>>>
>>> Thanks!
>>>
>>> Cheers,
>>> Miguel
>>
>> It's fairly different, and I discussed with both of them - we agreed
>> that Co-developed-by would not be appropriate.
> 
> I still agree that a Co-developed-by isn't appropriate, but I believe
> that it would be fair to mention me and Lina on the commit message.

I think I mentioned Inspired-by: as perhaps a nice alternative?

> 
> Best Regards,
> - Maíra
> 
>>
>> Thanks!
>> Tamir
> 
> 

~~ Lina

Re: [PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray
Posted by Tamir Duberstein 2 days, 1 hour ago
On Tue, Nov 19, 2024 at 7:26 AM Asahi Lina <lina@asahilina.net> wrote:
>
>
>
> On 11/19/24 8:11 PM, Maíra Canal wrote:
> > Hi Tamir & Miguel,
> >
> > On 18/11/24 14:02, Tamir Duberstein wrote:
> >> On Mon, Nov 18, 2024 at 11:52 AM Miguel Ojeda
> >> <miguel.ojeda.sandonis@gmail.com> wrote:
> >>>
> >>> On Mon, Nov 18, 2024 at 5:33 PM Tamir Duberstein <tamird@gmail.com>
> >>> wrote:
> >>>>
> >>>> This is a reimagining relative to earlier versions[0] by Asahi Lina and
> >>>> Maíra Canal.
> >>>
> >>> Maíra's latest version has both of them listed as co-authors in the
> >>> main patch -- how close is this to that version? (I see some bits that
> >>> look fairly similar)
> >>>
> >>> Thanks!
> >>>
> >>> Cheers,
> >>> Miguel
> >>
> >> It's fairly different, and I discussed with both of them - we agreed
> >> that Co-developed-by would not be appropriate.
> >
> > I still agree that a Co-developed-by isn't appropriate, but I believe
> > that it would be fair to mention me and Lina on the commit message.
>
> I think I mentioned Inspired-by: as perhaps a nice alternative?

Ah yes - will add in v2.
Re: [PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray
Posted by Tamir Duberstein 2 days, 1 hour ago
On Tue, Nov 19, 2024 at 9:21 AM Tamir Duberstein <tamird@gmail.com> wrote:
> Ah yes - will add in v2.

Err, I meant v10.
Re: [PATCH v9 0/2] rust: xarray: Add a minimal abstraction for XArray
Posted by Miguel Ojeda 2 days, 22 hours ago
On Mon, Nov 18, 2024 at 6:03 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> It's fairly different, and I discussed with both of them - we agreed
> that Co-developed-by would not be appropriate.

Thanks for clarifying!

Cheers,
Miguel