[v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe

[PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe

Posted by Nobuhiro Iwamatsu 1 year, 2 months ago

The return is executed on the devm_register_sys_off_handler() line in
as3722_poweroff_probe, so the last return line is unnecessary. Remove it.

Fixes: 348fde771ce7 ("power: reset: as3722-poweroff: Use devm_register_sys_off_handler(POWER_OFF)")
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 v2: Set correct mail address for Sebastian Reichel.

 drivers/power/reset/as3722-poweroff.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/power/reset/as3722-poweroff.c b/drivers/power/reset/as3722-poweroff.c
index bb26fa6fa67ca7..8075382cbc3625 100644
--- a/drivers/power/reset/as3722-poweroff.c
+++ b/drivers/power/reset/as3722-poweroff.c
@@ -57,8 +57,6 @@ static int as3722_poweroff_probe(struct platform_device *pdev)
 					     SYS_OFF_PRIO_DEFAULT,
 					     as3722_pm_power_off,
 					     as3722_poweroff);
-
-	return 0;
 }
 
 static struct platform_driver as3722_poweroff_driver = {
-- 
2.45.2

Re: [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe

Posted by Sebastian Reichel 1 year, 1 month ago

On Sun, 17 Nov 2024 14:34:43 +0900, Nobuhiro Iwamatsu wrote:
> The return is executed on the devm_register_sys_off_handler() line in
> as3722_poweroff_probe, so the last return line is unnecessary. Remove it.
> 
> 

Applied, thanks!

[1/1] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe
      commit: 156fb706f915ceb436200030e3730305bbf12f6c

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>

Re: [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe

Posted by Andrew Davis 1 year, 2 months ago

On 11/16/24 11:34 PM, Nobuhiro Iwamatsu wrote:
> The return is executed on the devm_register_sys_off_handler() line in
> as3722_poweroff_probe, so the last return line is unnecessary. Remove it.
> 
> Fixes: 348fde771ce7 ("power: reset: as3722-poweroff: Use devm_register_sys_off_handler(POWER_OFF)")
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---

Acked-by: Andrew Davis <afd@ti.com>

>   v2: Set correct mail address for Sebastian Reichel.
> 
>   drivers/power/reset/as3722-poweroff.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/reset/as3722-poweroff.c b/drivers/power/reset/as3722-poweroff.c
> index bb26fa6fa67ca7..8075382cbc3625 100644
> --- a/drivers/power/reset/as3722-poweroff.c
> +++ b/drivers/power/reset/as3722-poweroff.c
> @@ -57,8 +57,6 @@ static int as3722_poweroff_probe(struct platform_device *pdev)
>   					     SYS_OFF_PRIO_DEFAULT,
>   					     as3722_pm_power_off,
>   					     as3722_poweroff);
> -
> -	return 0;
>   }
>   
>   static struct platform_driver as3722_poweroff_driver = {