[PATCH v1] spmi: Set fwnode for spmi devices

Saravana Kannan posted 1 patch 1 year, 2 months ago
drivers/spmi/spmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v1] spmi: Set fwnode for spmi devices
Posted by Saravana Kannan 1 year, 2 months ago
This allows fw_devlink to do proper dependency tracking for SPMI
devices. So, better deferred probe handling, async probing, async
suspend/resume, etc.

Signed-off-by: Saravana Kannan <saravanak@google.com>
---
 drivers/spmi/spmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index fb0101da1485..3cf8d9bd4566 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -517,7 +517,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
 		if (!sdev)
 			continue;
 
-		sdev->dev.of_node = node;
+		device_set_node(&sdev->dev, of_fwnode_handle(node));
 		sdev->usid = (u8)reg[0];
 
 		err = spmi_device_add(sdev);
-- 
2.47.0.338.g60cca15819-goog
Re: [PATCH v1] spmi: Set fwnode for spmi devices
Posted by Stephen Boyd 1 year, 2 months ago
Quoting Saravana Kannan (2024-11-15 15:05:07)
> This allows fw_devlink to do proper dependency tracking for SPMI
> devices. So, better deferred probe handling, async probing, async
> suspend/resume, etc.
> 
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---

Applied to spmi-next
Re: [PATCH v1] spmi: Set fwnode for spmi devices
Posted by Saravana Kannan 1 year, 2 months ago
On Fri, Nov 15, 2024 at 3:05 PM Saravana Kannan <saravanak@google.com> wrote:
>
> This allows fw_devlink to do proper dependency tracking for SPMI
> devices. So, better deferred probe handling, async probing, async
> suspend/resume, etc.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>

Stephen,

Gentle nudge. Plan to take this in for 6.13?

-Saravana

> ---
>  drivers/spmi/spmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
> index fb0101da1485..3cf8d9bd4566 100644
> --- a/drivers/spmi/spmi.c
> +++ b/drivers/spmi/spmi.c
> @@ -517,7 +517,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
>                 if (!sdev)
>                         continue;
>
> -               sdev->dev.of_node = node;
> +               device_set_node(&sdev->dev, of_fwnode_handle(node));
>                 sdev->usid = (u8)reg[0];
>
>                 err = spmi_device_add(sdev);
> --
> 2.47.0.338.g60cca15819-goog
>
Re: [PATCH v1] spmi: Set fwnode for spmi devices
Posted by Stephen Boyd 1 year, 2 months ago
Quoting Saravana Kannan (2024-11-27 20:23:01)
> On Fri, Nov 15, 2024 at 3:05 PM Saravana Kannan <saravanak@google.com> wrote:
> >
> > This allows fw_devlink to do proper dependency tracking for SPMI
> > devices. So, better deferred probe handling, async probing, async
> > suspend/resume, etc.
> >
> > Signed-off-by: Saravana Kannan <saravanak@google.com>
> 
> Stephen,
> 
> Gentle nudge. Plan to take this in for 6.13?
> 

It doesn't look like a fix and it was sent too late for 6.13 so I was
going to send it over for the next cycle.
Re: [PATCH v1] spmi: Set fwnode for spmi devices
Posted by Saravana Kannan 1 year, 2 months ago
On Mon, Dec 2, 2024 at 3:27 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Saravana Kannan (2024-11-27 20:23:01)
> > On Fri, Nov 15, 2024 at 3:05 PM Saravana Kannan <saravanak@google.com> wrote:
> > >
> > > This allows fw_devlink to do proper dependency tracking for SPMI
> > > devices. So, better deferred probe handling, async probing, async
> > > suspend/resume, etc.
> > >
> > > Signed-off-by: Saravana Kannan <saravanak@google.com>
> >
> > Stephen,
> >
> > Gentle nudge. Plan to take this in for 6.13?
> >
>
> It doesn't look like a fix and it was sent too late for 6.13 so I was
> going to send it over for the next cycle.

Sounds good. Can you let me know once you pick it up in one of your
git branches?

Thanks,
Saravana