[PATCH net v2 4/5] rtase: Corrects error handling of the rtase_check_mac_version_valid()

Justin Lai posted 5 patches 1 week ago
[PATCH net v2 4/5] rtase: Corrects error handling of the rtase_check_mac_version_valid()
Posted by Justin Lai 1 week ago
Corrects error handling of the rtase_check_mac_version_valid().

Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
Signed-off-by: Justin Lai <justinlai0215@realtek.com>
---
 drivers/net/ethernet/realtek/rtase/rtase_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
index 22389911a7d4..91ad19e80f67 100644
--- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
+++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
@@ -2124,6 +2124,7 @@ static int rtase_init_one(struct pci_dev *pdev,
 		dev_err(&pdev->dev,
 			"unknown chip version: 0x%08x, contact rtase maintainers (see MAINTAINERS file)\n",
 			tp->hw_ver);
+		goto err_out_release_board;
 	}
 
 	rtase_init_software_variable(pdev, tp);
@@ -2198,6 +2199,7 @@ static int rtase_init_one(struct pci_dev *pdev,
 		netif_napi_del(&ivec->napi);
 	}
 
+err_out_release_board:
 	rtase_release_board(pdev, dev, ioaddr);
 
 	return ret;
-- 
2.34.1
Re: [PATCH net v2 4/5] rtase: Corrects error handling of the rtase_check_mac_version_valid()
Posted by Andrew Lunn 6 days, 9 hours ago
On Fri, Nov 15, 2024 at 05:54:28PM +0800, Justin Lai wrote:
> Corrects error handling of the rtase_check_mac_version_valid().
> 
> Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew