1. Add RTL907XD-VA hardware version id.
2. Add the reported speed for RTL907XD-VA.
Signed-off-by: Justin Lai <justinlai0215@realtek.com>
---
drivers/net/ethernet/realtek/rtase/rtase_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
index 5b8012987ea6..22389911a7d4 100644
--- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
+++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
@@ -1725,6 +1725,7 @@ static int rtase_get_settings(struct net_device *dev,
cmd->base.speed = SPEED_5000;
break;
case 0x04800000:
+ case 0x08000000:
cmd->base.speed = SPEED_10000;
break;
}
@@ -1993,6 +1994,7 @@ static int rtase_check_mac_version_valid(struct rtase_private *tp)
case 0x00800000:
case 0x04000000:
case 0x04800000:
+ case 0x08000000:
ret = 0;
break;
}
--
2.34.1
On Fri, Nov 15, 2024 at 05:54:27PM +0800, Justin Lai wrote: > 1. Add RTL907XD-VA hardware version id. > 2. Add the reported speed for RTL907XD-VA. This is not a fix, it never worked on this device as far as i see. So this should be for net-next. Please separate these patches out into real fixes, and new features. Andrew
> > On Fri, Nov 15, 2024 at 05:54:27PM +0800, Justin Lai wrote: > > 1. Add RTL907XD-VA hardware version id. > > 2. Add the reported speed for RTL907XD-VA. > > This is not a fix, it never worked on this device as far as i see. So > this should be for net-next. > > Please separate these patches out into real fixes, and new features. > > Andrew Thank you for your response. I will follow these guidelines for the categorization and upload the patch to net-next accordingly. I appreciate your assistance.
On 11/18/24 03:30, Justin Lai wrote: >> >> On Fri, Nov 15, 2024 at 05:54:27PM +0800, Justin Lai wrote: >>> 1. Add RTL907XD-VA hardware version id. >>> 2. Add the reported speed for RTL907XD-VA. >> >> This is not a fix, it never worked on this device as far as i see. So >> this should be for net-next. >> >> Please separate these patches out into real fixes, and new features. >> >> Andrew > > Thank you for your response. I will follow these guidelines for the > categorization and upload the patch to net-next accordingly. I appreciate > your assistance. Please re-post the series including net patches only and wait for the merge window completion (~2w from now) before posting the net-next patch. Thanks! Paolo
> On 11/18/24 03:30, Justin Lai wrote: > >> > >> On Fri, Nov 15, 2024 at 05:54:27PM +0800, Justin Lai wrote: > >>> 1. Add RTL907XD-VA hardware version id. > >>> 2. Add the reported speed for RTL907XD-VA. > >> > >> This is not a fix, it never worked on this device as far as i see. So > >> this should be for net-next. > >> > >> Please separate these patches out into real fixes, and new features. > >> > >> Andrew > > > > Thank you for your response. I will follow these guidelines for the > > categorization and upload the patch to net-next accordingly. I > > appreciate your assistance. > > Please re-post the series including net patches only and wait for the merge > window completion (~2w from now) before posting the net-next patch. > > Thanks! > > Paolo Hi Paolo Thank you for the notification. I have removed this patch from the latest patch set. Justin
© 2016 - 2024 Red Hat, Inc.