[PATCH v3] sched_ext: Replace scx_next_task_picked() with switch_class() in comment

Zhao Mengmeng posted 1 patch 1 week ago
kernel/sched/ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH v3] sched_ext: Replace scx_next_task_picked() with switch_class() in comment
Posted by Zhao Mengmeng 1 week ago
From: Zhao Mengmeng <zhaomengmeng@kylinos.cn>

scx_next_task_picked() has been replaced with siwtch_class(), but comment
is still referencing old one, so replace it.

Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
---
 kernel/sched/ext.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 0036696e7063..9f9bc2930658 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -2759,7 +2759,7 @@ static int balance_one(struct rq *rq, struct task_struct *prev)
 		 * If the previous sched_class for the current CPU was not SCX,
 		 * notify the BPF scheduler that it again has control of the
 		 * core. This callback complements ->cpu_release(), which is
-		 * emitted in scx_next_task_picked().
+		 * emitted in switch_class().
 		 */
 		if (SCX_HAS_OP(cpu_acquire))
 			SCX_CALL_OP(SCX_KF_REST, cpu_acquire, cpu_of(rq), NULL);
@@ -6091,7 +6091,7 @@ static void kick_cpus_irq_workfn(struct irq_work *irq_work)
 		if (cpu != cpu_of(this_rq)) {
 			/*
 			 * Pairs with smp_store_release() issued by this CPU in
-			 * scx_next_task_picked() on the resched path.
+			 * switch_class() on the resched path.
 			 *
 			 * We busy-wait here to guarantee that no other task can
 			 * be scheduled on our core before the target CPU has
-- 
2.43.0
Re: [PATCH v3] sched_ext: Replace scx_next_task_picked() with switch_class() in comment
Posted by Tejun Heo 1 week ago
On Fri, Nov 15, 2024 at 09:17:09AM +0800, Zhao Mengmeng wrote:
> From: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
> 
> scx_next_task_picked() has been replaced with siwtch_class(), but comment
> is still referencing old one, so replace it.
> 
> Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn>

Applied to sched_ext/for-6.13.

Thanks.

-- 
tejun