Add support for the new phone link hotkey on ThinkPads

[PATCH 1/2] Input: allocate keycode for phone linking

Posted by Illia Ostapyshyn 1 year, 2 months ago

The F11 key on the new Lenovo Thinkpad T14 Gen 5, T16 Gen 3, and P14s
Gen 5 laptops includes a symbol showing a smartphone and a laptop
chained together.  According to the user manual, it starts the Microsoft
Phone Link software used to connect to Android/iOS devices and relay
messages/calls or sync data.

As there are no suitable keycodes for this action, introduce a new one.

Signed-off-by: Illia Ostapyshyn <illia@yshyn.com>
---
 include/uapi/linux/input-event-codes.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index a4206723f503..5a199f3d4a26 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -519,6 +519,7 @@
 #define KEY_NOTIFICATION_CENTER	0x1bc	/* Show/hide the notification center */
 #define KEY_PICKUP_PHONE	0x1bd	/* Answer incoming call */
 #define KEY_HANGUP_PHONE	0x1be	/* Decline incoming call */
+#define KEY_LINK_PHONE		0x1bf   /* AL Phone Syncing */
 
 #define KEY_DEL_EOL		0x1c0
 #define KEY_DEL_EOS		0x1c1
-- 
2.47.0

Re: [PATCH 1/2] Input: allocate keycode for phone linking

Posted by Dmitry Torokhov 1 year ago

On Thu, Nov 14, 2024 at 06:39:29PM +0100, Illia Ostapyshyn wrote:
> The F11 key on the new Lenovo Thinkpad T14 Gen 5, T16 Gen 3, and P14s
> Gen 5 laptops includes a symbol showing a smartphone and a laptop
> chained together.  According to the user manual, it starts the Microsoft
> Phone Link software used to connect to Android/iOS devices and relay
> messages/calls or sync data.
> 
> As there are no suitable keycodes for this action, introduce a new one.
> 
> Signed-off-by: Illia Ostapyshyn <illia@yshyn.com>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Please feel free to merge with the corresponding driver change.

> ---
>  include/uapi/linux/input-event-codes.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index a4206723f503..5a199f3d4a26 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -519,6 +519,7 @@
>  #define KEY_NOTIFICATION_CENTER	0x1bc	/* Show/hide the notification center */
>  #define KEY_PICKUP_PHONE	0x1bd	/* Answer incoming call */
>  #define KEY_HANGUP_PHONE	0x1be	/* Decline incoming call */
> +#define KEY_LINK_PHONE		0x1bf   /* AL Phone Syncing */
>  
>  #define KEY_DEL_EOL		0x1c0
>  #define KEY_DEL_EOS		0x1c1
> -- 
> 2.47.0
> 

Thanks.

-- 
Dmitry

Re: [PATCH 1/2] Input: allocate keycode for phone linking

Posted by Ilpo Järvinen 1 year, 2 months ago

On Thu, 14 Nov 2024, Illia Ostapyshyn wrote:

> The F11 key on the new Lenovo Thinkpad T14 Gen 5, T16 Gen 3, and P14s
> Gen 5 laptops includes a symbol showing a smartphone and a laptop
> chained together.  According to the user manual, it starts the Microsoft
> Phone Link software used to connect to Android/iOS devices and relay
> messages/calls or sync data.
> 
> As there are no suitable keycodes for this action, introduce a new one.
> 
> Signed-off-by: Illia Ostapyshyn <illia@yshyn.com>
> ---
>  include/uapi/linux/input-event-codes.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index a4206723f503..5a199f3d4a26 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -519,6 +519,7 @@
>  #define KEY_NOTIFICATION_CENTER	0x1bc	/* Show/hide the notification center */
>  #define KEY_PICKUP_PHONE	0x1bd	/* Answer incoming call */
>  #define KEY_HANGUP_PHONE	0x1be	/* Decline incoming call */
> +#define KEY_LINK_PHONE		0x1bf   /* AL Phone Syncing */

Any thoughts about this Dmitry?

-- 
 i.

Re: [PATCH 1/2] Input: allocate keycode for phone linking

Posted by Ilpo Järvinen 1 year, 1 month ago

On Mon, 2 Dec 2024, Ilpo Järvinen wrote:
> On Thu, 14 Nov 2024, Illia Ostapyshyn wrote:
> 
> > The F11 key on the new Lenovo Thinkpad T14 Gen 5, T16 Gen 3, and P14s
> > Gen 5 laptops includes a symbol showing a smartphone and a laptop
> > chained together.  According to the user manual, it starts the Microsoft
> > Phone Link software used to connect to Android/iOS devices and relay
> > messages/calls or sync data.
> > 
> > As there are no suitable keycodes for this action, introduce a new one.
> > 
> > Signed-off-by: Illia Ostapyshyn <illia@yshyn.com>
> > ---
> >  include/uapi/linux/input-event-codes.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index a4206723f503..5a199f3d4a26 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -519,6 +519,7 @@
> >  #define KEY_NOTIFICATION_CENTER	0x1bc	/* Show/hide the notification center */
> >  #define KEY_PICKUP_PHONE	0x1bd	/* Answer incoming call */
> >  #define KEY_HANGUP_PHONE	0x1be	/* Decline incoming call */
> > +#define KEY_LINK_PHONE		0x1bf   /* AL Phone Syncing */
> 
> Any thoughts about this Dmitry?

Ping?

-- 
 i.