[PATCH net-next v2 00/10] net: freescale: ucc_geth: Phylink conversion

Maxime Chevallier posted 10 patches 1 week, 1 day ago
drivers/net/ethernet/freescale/Kconfig        |   3 +-
drivers/net/ethernet/freescale/ucc_geth.c     | 601 +++++++-----------
drivers/net/ethernet/freescale/ucc_geth.h     |  22 +-
.../net/ethernet/freescale/ucc_geth_ethtool.c |  74 +--
4 files changed, 265 insertions(+), 435 deletions(-)
[PATCH net-next v2 00/10] net: freescale: ucc_geth: Phylink conversion
Posted by Maxime Chevallier 1 week, 1 day ago
Hello everyone,

This is V2 of the ucc_geth phylink conversion.

There were two main reviews from the first iteration :

 - The WoL configuration was not accounting for most of the WoL flags.
   The Wol config was reworked (however, not tested unfortunately) to
   better account for what the PHY and MAC can deal with. However this
   is still a topic I'm not fully mastering... I think the modifications
   done to patch 4 addresses the shortcomings, but it does look a bit
   convoluted to me.

 - The last patch of the series, that does the phylink conversion, was
   hard to digest. To address that, I've split it up a bit more by
   introducing the phy_interface_mode_is_reduced() in a dedicated patch
   (patch 9), and by moving around some internal functions in a
   dedicated patch as well (patch 8).

Thanks Andrew and Russell for the reviews on V1.

Best regards,

Maxime

Link to V1: https://lore.kernel.org/netdev/20241107170255.1058124-1-maxime.chevallier@bootlin.com/

Maxime Chevallier (10):
  net: freescale: ucc_geth: Drop support for the "interface" DT property
  net: freescale: ucc_geth: split adjust_link for phylink conversion
  net: freescale: ucc_geth: Use netdev->phydev to access the PHY
  net: freescale: ucc_geth: Fix WOL configuration
  net: freescale: ucc_geth: Use the correct type to store WoL opts
  net: freescale: ucc_geth: Simplify frame length check
  net: freescale: ucc_geth: Hardcode the preamble length to 7 bytes
  net: freescale: ucc_geth: Move the serdes configuration around
  net: freescale: ucc_geth: Introduce a helper to check Reduced modes
  net: freescale: ucc_geth: phylink conversion

 drivers/net/ethernet/freescale/Kconfig        |   3 +-
 drivers/net/ethernet/freescale/ucc_geth.c     | 601 +++++++-----------
 drivers/net/ethernet/freescale/ucc_geth.h     |  22 +-
 .../net/ethernet/freescale/ucc_geth_ethtool.c |  74 +--
 4 files changed, 265 insertions(+), 435 deletions(-)

-- 
2.47.0