[PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register

Charles Han posted 1 patch 1 year, 2 months ago
drivers/clk/davinci/psc.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
Posted by Charles Han 1 year, 2 months ago
devm_kasprintf() can return a NULL pointer on failure,but this
returned value in davinci_lpsc_clk_register() is not checked.
Add NULL check in davinci_lpsc_clk_register(), to handle kernel NULL
pointer dereference error.

Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
 drivers/clk/davinci/psc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/davinci/psc.c b/drivers/clk/davinci/psc.c
index 355d1be0b5d8..bc271ea72721 100644
--- a/drivers/clk/davinci/psc.c
+++ b/drivers/clk/davinci/psc.c
@@ -277,6 +277,9 @@ davinci_lpsc_clk_register(struct device *dev, const char *name,
 
 	lpsc->pm_domain.name = devm_kasprintf(dev, GFP_KERNEL, "%s: %s",
 					      best_dev_name(dev), name);
+	if (!lpsc->pm_domain.name)
+		return -ENOMEM;
+
 	lpsc->pm_domain.attach_dev = davinci_psc_genpd_attach_dev;
 	lpsc->pm_domain.detach_dev = davinci_psc_genpd_detach_dev;
 	lpsc->pm_domain.flags = GENPD_FLAG_PM_CLK;
-- 
2.31.1
Re: [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
Posted by Stephen Boyd 1 year, 2 months ago
Quoting Charles Han (2024-11-14 01:14:22)
> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in davinci_lpsc_clk_register() is not checked.
> Add NULL check in davinci_lpsc_clk_register(), to handle kernel NULL
> pointer dereference error.
> 
> Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---

Applied to clk-next
Re: [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
Posted by David Lechner 1 year, 2 months ago
On 11/14/24 3:14 AM, Charles Han wrote:
> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in davinci_lpsc_clk_register() is not checked.
> Add NULL check in davinci_lpsc_clk_register(), to handle kernel NULL
> pointer dereference error.
> 
> Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---

Reviewed-by: David Lechner <david@lechnology.com>