dt-bindings: net: sff,sfp: Fix "interrupts" property typo

[PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo

Posted by Rob Herring (Arm) 1 week, 2 days ago

The example has "interrupt" property which is not a defined property. It
should be "interrupts" instead. "interrupts" also should not contain a
phandle.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/sff,sfp.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/sff,sfp.yaml b/Documentation/devicetree/bindings/net/sff,sfp.yaml
index 90611b598d2b..15616ad737f5 100644
--- a/Documentation/devicetree/bindings/net/sff,sfp.yaml
+++ b/Documentation/devicetree/bindings/net/sff,sfp.yaml
@@ -132,7 +132,7 @@ examples:
         pinctrl-names = "default";
         pinctrl-0 = <&cpm_phy0_pins &cps_phy0_pins>;
         reg = <0>;
-        interrupt = <&cpm_gpio2 18 IRQ_TYPE_EDGE_FALLING>;
+        interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
         sfp = <&sfp2>;
       };
     };
-- 
2.45.2

Re: [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo

Posted by Conor Dooley 1 week, 1 day ago

On Wed, Nov 13, 2024 at 04:58:25PM -0600, Rob Herring (Arm) wrote:
> The example has "interrupt" property which is not a defined property. It
> should be "interrupts" instead. "interrupts" also should not contain a
> phandle.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Re: [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo

Posted by Andrew Lunn 1 week, 1 day ago

On Wed, Nov 13, 2024 at 04:58:25PM -0600, Rob Herring (Arm) wrote:
> The example has "interrupt" property which is not a defined property. It
> should be "interrupts" instead. "interrupts" also should not contain a
> phandle.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew