dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode"

[PATCH net-next] dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode"

Posted by Rob Herring (Arm) 1 week, 2 days ago

"micrel,led-mode" is not yet documented by a schema. It's irrelevant to
the example, so just drop it.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml
index 29355ab98569..ced1471c6484 100644
--- a/Documentation/devicetree/bindings/net/renesas,ether.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml
@@ -123,7 +123,6 @@ examples:
             reg = <1>;
             interrupt-parent = <&irqc0>;
             interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
-            micrel,led-mode = <1>;
             reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>;
         };
     };
-- 
2.45.2

Re: [PATCH net-next] dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode"

Posted by Rob Herring 4 days, 5 hours ago

On Wed, Nov 13, 2024 at 4:58 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> "micrel,led-mode" is not yet documented by a schema. It's irrelevant to
> the example, so just drop it.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 -
>  1 file changed, 1 deletion(-)

I see this is marked rejected in PW. While there was some discussion,
there aren't any objections to it. While micrel.txt binding is being
converted now, there are some issues (with it and phy bindings in
general). Keeping this property in this example will eventually
require some changes to it. What phy is connected to this ethernet
controller is beyond the scope of this binding, so having a specific
phy is not necessary.

Rob

pw-bot: new

Re: [PATCH net-next] dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode"

Posted by Conor Dooley 1 week, 1 day ago

On Wed, Nov 13, 2024 at 04:57:42PM -0600, Rob Herring (Arm) wrote:
> "micrel,led-mode" is not yet documented by a schema. It's irrelevant to
> the example, so just drop it.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Re: [PATCH net-next] dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode"

Posted by Sergey Shtylyov 1 week, 1 day ago

On 11/14/24 1:57 AM, Rob Herring (Arm) wrote:

> "micrel,led-mode" is not yet documented by a schema. It's irrelevant to

   It's documented by Documentation/devicetree/bindings/net/micrel.txt...
Do you mean this one should be converted to .yaml?

> the example, so just drop it.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml
> index 29355ab98569..ced1471c6484 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml
> @@ -123,7 +123,6 @@ examples:
>              reg = <1>;
>              interrupt-parent = <&irqc0>;
>              interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> -            micrel,led-mode = <1>;
>              reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>;
>          };
>      };

MBR, Sergey

Re: [PATCH net-next] dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode"

Posted by Geert Uytterhoeven 1 week, 1 day ago

Hi Rob,

On Wed, Nov 13, 2024 at 11:58 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> "micrel,led-mode" is not yet documented by a schema. It's irrelevant to

Not anymore ;-)

https://lore.kernel.org/943cb31d01d0da3a63911326e24fbf9b328f7206.1731580776.git.geert+renesas@glider.be

> the example, so just drop it.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Regardless
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds