On 13/11/2024 11:13, Shinas Rasheed wrote:
> During unload, at times the OQ parsed in the napi callbacks
> have been observed to be null, causing system crash.
> Add protective checks to avoid the same, for cnxk cards.
>
> Fixes: 0807dc76f3bf ("octeon_ep: support Octeon CN10K devices")
> Signed-off-by: Shinas Rasheed <srasheed@marvell.com>
> ---
> V4:
> - No Changes
>
> V3: https://lore.kernel.org/all/20241108074543.1123036-5-srasheed@marvell.com/
> - Added back "Fixes" to the changelist
>
> V2: https://lore.kernel.org/all/20241107132846.1118835-5-srasheed@marvell.com/
> - Split into a separate patch
> - Added more context
>
> V1: https://lore.kernel.org/all/20241101103416.1064930-3-srasheed@marvell.com/
>
> drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c b/drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c
> index 5de0b5ecbc5f..65a8dc1d492b 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c
> @@ -638,7 +638,14 @@ static irqreturn_t octep_rsvd_intr_handler_cnxk_pf(void *dev)
> static irqreturn_t octep_ioq_intr_handler_cnxk_pf(void *data)
> {
> struct octep_ioq_vector *vector = (struct octep_ioq_vector *)data;
> - struct octep_oq *oq = vector->oq;
> + struct octep_oq *oq;
> +
> + if (!vector)
> + return IRQ_HANDLED;
The same comment as for the previous patch - this can never happen, the
check is meaningless
> + oq = vector->oq;
> +
> + if (!oq || !(oq->napi))
> + return IRQ_HANDLED;
>
> napi_schedule_irqoff(oq->napi);
> return IRQ_HANDLED;