smb: client: Use str_yes_no() helper function

[PATCH] smb: client: Use str_yes_no() helper function

Posted by Thorsten Blum 1 week, 4 days ago

Remove hard-coded strings by using the str_yes_no() helper function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/smb/client/dfs_cache.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/smb/client/dfs_cache.c b/fs/smb/client/dfs_cache.c
index 110f03df012a..00820f57b434 100644
--- a/fs/smb/client/dfs_cache.c
+++ b/fs/smb/client/dfs_cache.c
@@ -173,8 +173,8 @@ static int dfscache_proc_show(struct seq_file *m, void *v)
 				   "cache entry: path=%s,type=%s,ttl=%d,etime=%ld,hdr_flags=0x%x,ref_flags=0x%x,interlink=%s,path_consumed=%d,expired=%s\n",
 				   ce->path, ce->srvtype == DFS_TYPE_ROOT ? "root" : "link",
 				   ce->ttl, ce->etime.tv_nsec, ce->hdr_flags, ce->ref_flags,
-				   DFS_INTERLINK(ce->hdr_flags) ? "yes" : "no",
-				   ce->path_consumed, cache_entry_expired(ce) ? "yes" : "no");
+				   str_yes_no(DFS_INTERLINK(ce->hdr_flags)),
+				   ce->path_consumed, str_yes_no(cache_entry_expired(ce)));
 
 			list_for_each_entry(t, &ce->tlist, list) {
 				seq_printf(m, "  %s%s\n",
@@ -242,9 +242,9 @@ static inline void dump_ce(const struct cache_entry *ce)
 		 ce->srvtype == DFS_TYPE_ROOT ? "root" : "link", ce->ttl,
 		 ce->etime.tv_nsec,
 		 ce->hdr_flags, ce->ref_flags,
-		 DFS_INTERLINK(ce->hdr_flags) ? "yes" : "no",
+		 str_yes_no(DFS_INTERLINK(ce->hdr_flags)),
 		 ce->path_consumed,
-		 cache_entry_expired(ce) ? "yes" : "no");
+		 str_yes_no(cache_entry_expired(ce)));
 	dump_tgts(ce);
 }
 
-- 
2.47.0

Re: [PATCH] smb: client: Use str_yes_no() helper function

Posted by Steve French 1 week, 2 days ago

tentatively merged into cifs-2.6.git for-next pending testing and
additional review

On Tue, Nov 12, 2024 at 5:33 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_yes_no() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  fs/smb/client/dfs_cache.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/smb/client/dfs_cache.c b/fs/smb/client/dfs_cache.c
> index 110f03df012a..00820f57b434 100644
> --- a/fs/smb/client/dfs_cache.c
> +++ b/fs/smb/client/dfs_cache.c
> @@ -173,8 +173,8 @@ static int dfscache_proc_show(struct seq_file *m, void *v)
>                                    "cache entry: path=%s,type=%s,ttl=%d,etime=%ld,hdr_flags=0x%x,ref_flags=0x%x,interlink=%s,path_consumed=%d,expired=%s\n",
>                                    ce->path, ce->srvtype == DFS_TYPE_ROOT ? "root" : "link",
>                                    ce->ttl, ce->etime.tv_nsec, ce->hdr_flags, ce->ref_flags,
> -                                  DFS_INTERLINK(ce->hdr_flags) ? "yes" : "no",
> -                                  ce->path_consumed, cache_entry_expired(ce) ? "yes" : "no");
> +                                  str_yes_no(DFS_INTERLINK(ce->hdr_flags)),
> +                                  ce->path_consumed, str_yes_no(cache_entry_expired(ce)));
>
>                         list_for_each_entry(t, &ce->tlist, list) {
>                                 seq_printf(m, "  %s%s\n",
> @@ -242,9 +242,9 @@ static inline void dump_ce(const struct cache_entry *ce)
>                  ce->srvtype == DFS_TYPE_ROOT ? "root" : "link", ce->ttl,
>                  ce->etime.tv_nsec,
>                  ce->hdr_flags, ce->ref_flags,
> -                DFS_INTERLINK(ce->hdr_flags) ? "yes" : "no",
> +                str_yes_no(DFS_INTERLINK(ce->hdr_flags)),
>                  ce->path_consumed,
> -                cache_entry_expired(ce) ? "yes" : "no");
> +                str_yes_no(cache_entry_expired(ce)));
>         dump_tgts(ce);
>  }
>
> --
> 2.47.0
>
>


-- 
Thanks,

Steve