Adds a new keypad driver for the MA35D1 platform.
The driver supports key scanning and interrupt handling.
Signed-off-by: mjchen <mjchen0829@gmail.com>
---
drivers/input/keyboard/Kconfig | 10 +
drivers/input/keyboard/Makefile | 1 +
drivers/input/keyboard/ma35d1_keypad.c | 308 +++++++++++++++++++++++++
3 files changed, 319 insertions(+)
create mode 100644 drivers/input/keyboard/ma35d1_keypad.c
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 721ab69e84ac..d7c0d0f4a88d 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -797,4 +797,14 @@ config KEYBOARD_CYPRESS_SF
To compile this driver as a module, choose M here: the
module will be called cypress-sf.
+config KEYBOARD_MA35D1
+ tristate "Nuvoton MA35D1 keypad driver"
+ depends on ARCH_MA35 || COMPILE_TEST
+ select INPUT_MATRIXKMAP
+ help
+ Say Y here if you want to use Nuvoton MA35D1 keypad.
+
+ To compile this driver as a module, choose M here: the
+ module will be called ma35d1-keypad.
+
endif
diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
index 1e0721c30709..9b858cdd1b6b 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -70,3 +70,4 @@ obj-$(CONFIG_KEYBOARD_TEGRA) += tegra-kbc.o
obj-$(CONFIG_KEYBOARD_TM2_TOUCHKEY) += tm2-touchkey.o
obj-$(CONFIG_KEYBOARD_TWL4030) += twl4030_keypad.o
obj-$(CONFIG_KEYBOARD_XTKBD) += xtkbd.o
+obj-$(CONFIG_KEYBOARD_MA35D1) += ma35d1_keypad.o
diff --git a/drivers/input/keyboard/ma35d1_keypad.c b/drivers/input/keyboard/ma35d1_keypad.c
new file mode 100644
index 000000000000..be7ff4f49e8c
--- /dev/null
+++ b/drivers/input/keyboard/ma35d1_keypad.c
@@ -0,0 +1,308 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * MA35D1 keypad driver
+ * Copyright (C) 2024 Nuvoton Technology Corp.
+ */
+
+#include <linux/interrupt.h>
+#include <linux/input.h>
+#include <linux/platform_device.h>
+#include <linux/input/matrix_keypad.h>
+#include <linux/clk.h>
+#include <linux/of.h>
+#include <linux/bitops.h>
+#include <linux/pm_wakeirq.h>
+
+/* Keypad Interface Registers */
+#define KPI_CONF 0x00
+#define KPI_3KCONF 0x04
+#define KPI_STATUS 0x08
+#define KPI_RSTC 0x0C
+#define KPI_KEST 0x10
+#define KPI_KPE0 0x18
+#define KPI_KPE1 0x1C
+#define KPI_KRE0 0x20
+#define KPI_KRE1 0x24
+#define KPI_PRESCALDIV 0x28
+
+/* KPI_CONF - Keypad Configuration Register */
+#define KROW GENMASK(30, 28) /* Keypad Matrix ROW number */
+#define KCOL GENMASK(26, 24) /* Keypad Matrix COL Number */
+#define DB_CLKSEL GENMASK(19, 16) /* De-bounce sampling cycle selection */
+#define PRESCALE GENMASK(15, 8) /* Row Scan Cycle Pre-scale Value */
+#define WAKEUP BIT(5) /* Lower Power Wakeup Enable */
+#define INTEN BIT(3) /* Key Interrupt Enable Control */
+#define RKINTEN BIT(2) /* Release Key Interrupt Enable */
+#define PKINTEN BIT(1) /* Press Key Interrupt Enable Control */
+#define ENKP BIT(0) /* Keypad Scan Enable */
+
+/* KPI_STATUS - Keypad Status Register */
+#define PKEY_INT BIT(4) /* Press key interrupt */
+#define RKEY_INT BIT(3) /* Release key interrupt */
+#define KEY_INT BIT(2) /* Key Interrupt */
+#define RST_3KEY BIT(1) /* 3-Keys Reset Flag */
+#define PDWAKE BIT(0) /* Power Down Wakeup Flag */
+
+#define KEY_EVENT_BITS 64
+
+struct ma35d1_keypad {
+ struct clk *clk;
+ struct input_dev *input_dev;
+ void __iomem *mmio_base;
+ int irq;
+ unsigned int kpi_row;
+ unsigned int kpi_col;
+ unsigned int debounce_val;
+ unsigned int pre_scale;
+ unsigned int pre_scale_divider;
+};
+
+static void ma35d1_keypad_scan_matrix(struct ma35d1_keypad *keypad, unsigned int status)
+{
+ struct input_dev *input_dev = keypad->input_dev;
+ unsigned int code;
+ unsigned int key;
+ unsigned long pressed_keys = 0, released_keys = 0;
+ unsigned int row_shift = get_count_order(keypad->kpi_col);
+ unsigned short *keymap = input_dev->keycode;
+ unsigned long key_event[4];
+ unsigned int index;
+
+ /* Read key event status */
+ key_event[0] = readl(keypad->mmio_base + KPI_KPE0);
+ key_event[1] = readl(keypad->mmio_base + KPI_KPE1);
+ key_event[2] = readl(keypad->mmio_base + KPI_KRE0);
+ key_event[3] = readl(keypad->mmio_base + KPI_KRE1);
+
+ /* Clear key event status */
+ writel(key_event[0], (keypad->mmio_base + KPI_KPE0));
+ writel(key_event[1], (keypad->mmio_base + KPI_KPE1));
+ writel(key_event[2], (keypad->mmio_base + KPI_KRE0));
+ writel(key_event[3], (keypad->mmio_base + KPI_KRE1));
+
+ pressed_keys = key_event[0] | key_event[1] << 32;
+ released_keys = key_event[2] | key_event[3] << 32;
+
+ /* Process pressed keys */
+ for_each_set_bit(index, &pressed_keys, KEY_EVENT_BITS) {
+ code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift);
+ key = keymap[code];
+
+ input_event(input_dev, EV_MSC, MSC_SCAN, code);
+ input_report_key(input_dev, key, 1);
+ }
+
+ /* Process released keys */
+ for_each_set_bit(index, &released_keys, KEY_EVENT_BITS) {
+ code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift);
+ key = keymap[code];
+
+ input_event(input_dev, EV_MSC, MSC_SCAN, code);
+ input_report_key(input_dev, key, 0);
+ }
+
+ input_sync(input_dev);
+}
+
+static irqreturn_t ma35d1_keypad_interrupt(int irq, void *dev_id)
+{
+ struct ma35d1_keypad *keypad = dev_id;
+ unsigned int kstatus;
+
+ kstatus = readl(keypad->mmio_base + KPI_STATUS);
+
+ if (kstatus & (PKEY_INT | RKEY_INT)) {
+ ma35d1_keypad_scan_matrix(keypad, kstatus);
+ } else {
+ if (kstatus & PDWAKE)
+ writel(PDWAKE, (keypad->mmio_base + KPI_STATUS));
+ }
+
+ return IRQ_HANDLED;
+}
+
+static int ma35d1_keypad_open(struct input_dev *dev)
+{
+ struct ma35d1_keypad *keypad = input_get_drvdata(dev);
+ unsigned int val, config;
+
+ val = RKINTEN | PKINTEN | INTEN | ENKP;
+ val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1));
+
+ if (keypad->debounce_val > 0)
+ config = FIELD_PREP(PRESCALE, (keypad->pre_scale - 1)) |
+ FIELD_PREP(DB_CLKSEL, keypad->debounce_val);
+ else
+ config = FIELD_PREP(PRESCALE, (keypad->pre_scale - 1));
+
+ val |= config;
+
+ writel(val, keypad->mmio_base + KPI_CONF);
+ writel((keypad->pre_scale_divider - 1), keypad->mmio_base + KPI_PRESCALDIV);
+
+ return 0;
+}
+
+static void ma35d1_keypad_close(struct input_dev *dev)
+{
+ struct ma35d1_keypad *keypad = input_get_drvdata(dev);
+ unsigned int val;
+
+ val = readl(keypad->mmio_base + KPI_KPE0) & ~ENKP;
+ writel(val, keypad->mmio_base + KPI_CONF);
+}
+
+static int ma35d1_keypad_probe(struct platform_device *pdev)
+{
+ struct ma35d1_keypad *keypad;
+ struct input_dev *input_dev;
+ struct resource *res;
+ int error = 0;
+
+ keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
+ if (!keypad)
+ return -ENOMEM;
+
+ input_dev = devm_input_allocate_device(&pdev->dev);
+ if (!input_dev)
+ return -ENOMEM;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res)
+ return -ENODEV;
+
+ keypad->mmio_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(keypad->mmio_base))
+ return dev_err_probe(&pdev->dev, PTR_ERR(keypad->mmio_base),
+ "failed to remap I/O memor\n");
+
+ keypad->irq = platform_get_irq(pdev, 0);
+ if (keypad->irq < 0) {
+ dev_err(&pdev->dev, "failed to get IRQ\n");
+ return keypad->irq;
+ }
+
+ keypad->clk = devm_clk_get_enabled(&pdev->dev, NULL);
+ if (IS_ERR(keypad->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(keypad->clk), "failed to get core clk\n");
+
+ error = matrix_keypad_parse_properties(&pdev->dev, &keypad->kpi_row, &keypad->kpi_col);
+ if (error) {
+ dev_err(&pdev->dev, "failed to parse keypad params\n");
+ return error;
+ }
+
+ error = matrix_keypad_build_keymap(NULL, NULL, keypad->kpi_row, keypad->kpi_col,
+ NULL, input_dev);
+ if (error) {
+ dev_err(&pdev->dev, "failed to build keymap\n");
+ return error;
+ }
+
+ keypad->input_dev = input_dev;
+ input_dev->name = pdev->name;
+ input_dev->id.bustype = BUS_HOST;
+ input_dev->open = ma35d1_keypad_open;
+ input_dev->close = ma35d1_keypad_close;
+ input_dev->dev.parent = &pdev->dev;
+
+ error = device_property_read_u32(&pdev->dev, "debounce-period", &keypad->debounce_val);
+ if (error) {
+ dev_err(&pdev->dev, "failed to acquire 'debounce-period'\n");
+ return error;
+ }
+
+ keypad->debounce_val = __builtin_ctz(keypad->debounce_val);
+
+ error = device_property_read_u32(&pdev->dev, "key-scan-time", &keypad->pre_scale);
+ if (error) {
+ dev_err(&pdev->dev, "failed to acquire 'key-scan-time'\n");
+ return error;
+ }
+
+ device_property_read_u32(&pdev->dev, "key-scan-time-div", &keypad->pre_scale_divider);
+ if (error) {
+ dev_err(&pdev->dev, "failed to acquire 'key-scan-time-div'\n");
+ return error;
+ }
+
+ __set_bit(EV_REP, input_dev->evbit);
+ input_set_drvdata(input_dev, keypad);
+ input_set_capability(input_dev, EV_MSC, MSC_SCAN);
+
+ error = devm_request_irq(&pdev->dev, keypad->irq, ma35d1_keypad_interrupt,
+ IRQF_NO_SUSPEND, pdev->name, keypad);
+ if (error) {
+ dev_err(&pdev->dev, "failed to request IRQ\n");
+ return error;
+ }
+
+ platform_set_drvdata(pdev, keypad);
+ device_init_wakeup(&pdev->dev, 1);
+
+ error = dev_pm_set_wake_irq(&pdev->dev, keypad->irq);
+ if (error) {
+ dev_err(&pdev->dev, "failed to enable irq wake\n");
+ return error;
+ }
+
+ error = input_register_device(input_dev);
+ if (error) {
+ dev_err(&pdev->dev, "failed to register input device\n");
+ return error;
+ }
+
+ return 0;
+}
+
+static void ma35d1_keypad_remove(struct platform_device *pdev)
+{
+ struct ma35d1_keypad *keypad = platform_get_drvdata(pdev);
+
+ input_unregister_device(keypad->input_dev);
+}
+
+static int ma35d1_keypad_suspend(struct device *dev)
+{
+ struct ma35d1_keypad *keypad = dev_get_drvdata(dev);
+
+ if (device_may_wakeup(dev))
+ writel(readl(keypad->mmio_base + KPI_CONF) | WAKEUP, keypad->mmio_base + KPI_CONF);
+
+ return 0;
+}
+
+static int ma35d1_keypad_resume(struct device *dev)
+{
+ struct ma35d1_keypad *keypad = dev_get_drvdata(dev);
+
+ if (device_may_wakeup(dev))
+ writel(readl(keypad->mmio_base + KPI_CONF) & ~(WAKEUP),
+ keypad->mmio_base + KPI_CONF);
+
+ return 0;
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(ma35d1_pm_ops, ma35d1_keypad_suspend, ma35d1_keypad_resume);
+
+static const struct of_device_id ma35d1_kpi_of_match[] = {
+ { .compatible = "nuvoton,ma35d1-kpi"},
+ {},
+};
+MODULE_DEVICE_TABLE(of, ma35d1_kpi_of_match);
+
+static struct platform_driver ma35d1_keypad_driver = {
+ .probe = ma35d1_keypad_probe,
+ .remove = ma35d1_keypad_remove,
+ .driver = {
+ .name = "ma35d1-kpi",
+ .pm = pm_sleep_ptr(&ma35d1_pm_ops),
+ .of_match_table = ma35d1_kpi_of_match,
+ },
+};
+module_platform_driver(ma35d1_keypad_driver);
+
+MODULE_AUTHOR("Ming-Jen Chen");
+MODULE_DESCRIPTION("MA35D1 Keypad Driver");
+MODULE_LICENSE("GPL");
+
--
2.25.1Hi mjchen,
kernel test robot noticed the following build warnings:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on dtor-input/for-linus robh/for-next soc/for-next linus/master v6.12-rc7 next-20241112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/mjchen/dt-bindings-input-Add-Nuvoton-MA35D1-keypad/20241112-133327
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20241112053059.3361-3-mjchen0829%40gmail.com
patch subject: [PATCH v2 2/2] input: keypad: add new keypad driver for MA35D1
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20241112/202411122236.79vmA2JS-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241112/202411122236.79vmA2JS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411122236.79vmA2JS-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/input/keyboard/ma35d1_keypad.c:7:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/input/keyboard/ma35d1_keypad.c:7:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/input/keyboard/ma35d1_keypad.c:7:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
>> drivers/input/keyboard/ma35d1_keypad.c:83:46: warning: shift count >= width of type [-Wshift-count-overflow]
83 | pressed_keys = key_event[0] | key_event[1] << 32;
| ^ ~~
drivers/input/keyboard/ma35d1_keypad.c:84:46: warning: shift count >= width of type [-Wshift-count-overflow]
84 | released_keys = key_event[2] | key_event[3] << 32;
| ^ ~~
drivers/input/keyboard/ma35d1_keypad.c:130:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
130 | val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1));
| ^
8 warnings and 1 error generated.
vim +83 drivers/input/keyboard/ma35d1_keypad.c
59
60 static void ma35d1_keypad_scan_matrix(struct ma35d1_keypad *keypad, unsigned int status)
61 {
62 struct input_dev *input_dev = keypad->input_dev;
63 unsigned int code;
64 unsigned int key;
65 unsigned long pressed_keys = 0, released_keys = 0;
66 unsigned int row_shift = get_count_order(keypad->kpi_col);
67 unsigned short *keymap = input_dev->keycode;
68 unsigned long key_event[4];
69 unsigned int index;
70
71 /* Read key event status */
72 key_event[0] = readl(keypad->mmio_base + KPI_KPE0);
73 key_event[1] = readl(keypad->mmio_base + KPI_KPE1);
74 key_event[2] = readl(keypad->mmio_base + KPI_KRE0);
75 key_event[3] = readl(keypad->mmio_base + KPI_KRE1);
76
77 /* Clear key event status */
78 writel(key_event[0], (keypad->mmio_base + KPI_KPE0));
79 writel(key_event[1], (keypad->mmio_base + KPI_KPE1));
80 writel(key_event[2], (keypad->mmio_base + KPI_KRE0));
81 writel(key_event[3], (keypad->mmio_base + KPI_KRE1));
82
> 83 pressed_keys = key_event[0] | key_event[1] << 32;
84 released_keys = key_event[2] | key_event[3] << 32;
85
86 /* Process pressed keys */
87 for_each_set_bit(index, &pressed_keys, KEY_EVENT_BITS) {
88 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift);
89 key = keymap[code];
90
91 input_event(input_dev, EV_MSC, MSC_SCAN, code);
92 input_report_key(input_dev, key, 1);
93 }
94
95 /* Process released keys */
96 for_each_set_bit(index, &released_keys, KEY_EVENT_BITS) {
97 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift);
98 key = keymap[code];
99
100 input_event(input_dev, EV_MSC, MSC_SCAN, code);
101 input_report_key(input_dev, key, 0);
102 }
103
104 input_sync(input_dev);
105 }
106
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi mjchen,
kernel test robot noticed the following build errors:
[auto build test ERROR on dtor-input/next]
[also build test ERROR on dtor-input/for-linus robh/for-next soc/for-next linus/master v6.12-rc7 next-20241112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/mjchen/dt-bindings-input-Add-Nuvoton-MA35D1-keypad/20241112-133327
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20241112053059.3361-3-mjchen0829%40gmail.com
patch subject: [PATCH v2 2/2] input: keypad: add new keypad driver for MA35D1
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241112/202411121938.AoeMusUF-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241112/202411121938.AoeMusUF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411121938.AoeMusUF-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/input/keyboard/ma35d1_keypad.c:7:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/input/keyboard/ma35d1_keypad.c:7:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/input/keyboard/ma35d1_keypad.c:7:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
drivers/input/keyboard/ma35d1_keypad.c:83:46: warning: shift count >= width of type [-Wshift-count-overflow]
83 | pressed_keys = key_event[0] | key_event[1] << 32;
| ^ ~~
drivers/input/keyboard/ma35d1_keypad.c:84:46: warning: shift count >= width of type [-Wshift-count-overflow]
84 | released_keys = key_event[2] | key_event[3] << 32;
| ^ ~~
>> drivers/input/keyboard/ma35d1_keypad.c:130:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
130 | val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1));
| ^
8 warnings and 1 error generated.
vim +/FIELD_PREP +130 drivers/input/keyboard/ma35d1_keypad.c
123
124 static int ma35d1_keypad_open(struct input_dev *dev)
125 {
126 struct ma35d1_keypad *keypad = input_get_drvdata(dev);
127 unsigned int val, config;
128
129 val = RKINTEN | PKINTEN | INTEN | ENKP;
> 130 val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1));
131
132 if (keypad->debounce_val > 0)
133 config = FIELD_PREP(PRESCALE, (keypad->pre_scale - 1)) |
134 FIELD_PREP(DB_CLKSEL, keypad->debounce_val);
135 else
136 config = FIELD_PREP(PRESCALE, (keypad->pre_scale - 1));
137
138 val |= config;
139
140 writel(val, keypad->mmio_base + KPI_CONF);
141 writel((keypad->pre_scale_divider - 1), keypad->mmio_base + KPI_PRESCALDIV);
142
143 return 0;
144 }
145
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi mjchen,
kernel test robot noticed the following build errors:
[auto build test ERROR on dtor-input/next]
[also build test ERROR on dtor-input/for-linus robh/for-next soc/for-next linus/master v6.12-rc7 next-20241112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/mjchen/dt-bindings-input-Add-Nuvoton-MA35D1-keypad/20241112-133327
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20241112053059.3361-3-mjchen0829%40gmail.com
patch subject: [PATCH v2 2/2] input: keypad: add new keypad driver for MA35D1
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20241112/202411121749.9xapQvza-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241112/202411121749.9xapQvza-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411121749.9xapQvza-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/input/keyboard/ma35d1_keypad.c: In function 'ma35d1_keypad_scan_matrix':
>> drivers/input/keyboard/ma35d1_keypad.c:83:53: warning: left shift count >= width of type [-Wshift-count-overflow]
83 | pressed_keys = key_event[0] | key_event[1] << 32;
| ^~
drivers/input/keyboard/ma35d1_keypad.c:84:53: warning: left shift count >= width of type [-Wshift-count-overflow]
84 | released_keys = key_event[2] | key_event[3] << 32;
| ^~
drivers/input/keyboard/ma35d1_keypad.c: In function 'ma35d1_keypad_open':
>> drivers/input/keyboard/ma35d1_keypad.c:130:16: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
130 | val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1));
| ^~~~~~~~~~
vim +/FIELD_PREP +130 drivers/input/keyboard/ma35d1_keypad.c
59
60 static void ma35d1_keypad_scan_matrix(struct ma35d1_keypad *keypad, unsigned int status)
61 {
62 struct input_dev *input_dev = keypad->input_dev;
63 unsigned int code;
64 unsigned int key;
65 unsigned long pressed_keys = 0, released_keys = 0;
66 unsigned int row_shift = get_count_order(keypad->kpi_col);
67 unsigned short *keymap = input_dev->keycode;
68 unsigned long key_event[4];
69 unsigned int index;
70
71 /* Read key event status */
72 key_event[0] = readl(keypad->mmio_base + KPI_KPE0);
73 key_event[1] = readl(keypad->mmio_base + KPI_KPE1);
74 key_event[2] = readl(keypad->mmio_base + KPI_KRE0);
75 key_event[3] = readl(keypad->mmio_base + KPI_KRE1);
76
77 /* Clear key event status */
78 writel(key_event[0], (keypad->mmio_base + KPI_KPE0));
79 writel(key_event[1], (keypad->mmio_base + KPI_KPE1));
80 writel(key_event[2], (keypad->mmio_base + KPI_KRE0));
81 writel(key_event[3], (keypad->mmio_base + KPI_KRE1));
82
> 83 pressed_keys = key_event[0] | key_event[1] << 32;
84 released_keys = key_event[2] | key_event[3] << 32;
85
86 /* Process pressed keys */
87 for_each_set_bit(index, &pressed_keys, KEY_EVENT_BITS) {
88 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift);
89 key = keymap[code];
90
91 input_event(input_dev, EV_MSC, MSC_SCAN, code);
92 input_report_key(input_dev, key, 1);
93 }
94
95 /* Process released keys */
96 for_each_set_bit(index, &released_keys, KEY_EVENT_BITS) {
97 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift);
98 key = keymap[code];
99
100 input_event(input_dev, EV_MSC, MSC_SCAN, code);
101 input_report_key(input_dev, key, 0);
102 }
103
104 input_sync(input_dev);
105 }
106
107 static irqreturn_t ma35d1_keypad_interrupt(int irq, void *dev_id)
108 {
109 struct ma35d1_keypad *keypad = dev_id;
110 unsigned int kstatus;
111
112 kstatus = readl(keypad->mmio_base + KPI_STATUS);
113
114 if (kstatus & (PKEY_INT | RKEY_INT)) {
115 ma35d1_keypad_scan_matrix(keypad, kstatus);
116 } else {
117 if (kstatus & PDWAKE)
118 writel(PDWAKE, (keypad->mmio_base + KPI_STATUS));
119 }
120
121 return IRQ_HANDLED;
122 }
123
124 static int ma35d1_keypad_open(struct input_dev *dev)
125 {
126 struct ma35d1_keypad *keypad = input_get_drvdata(dev);
127 unsigned int val, config;
128
129 val = RKINTEN | PKINTEN | INTEN | ENKP;
> 130 val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1));
131
132 if (keypad->debounce_val > 0)
133 config = FIELD_PREP(PRESCALE, (keypad->pre_scale - 1)) |
134 FIELD_PREP(DB_CLKSEL, keypad->debounce_val);
135 else
136 config = FIELD_PREP(PRESCALE, (keypad->pre_scale - 1));
137
138 val |= config;
139
140 writel(val, keypad->mmio_base + KPI_CONF);
141 writel((keypad->pre_scale_divider - 1), keypad->mmio_base + KPI_PRESCALDIV);
142
143 return 0;
144 }
145
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
© 2016 - 2025 Red Hat, Inc.