samples: pktgen: correct dev to DEV

[PATCH net] samples: pktgen: correct dev to DEV

Posted by Wei Fang 1 year, 2 months ago

In the pktgen_sample01_simple.sh script, the device variable is uppercase
'DEV' instead of lowercase 'dev'. Because of this typo, the script cannot
enable UDP tx checksum.

Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 samples/pktgen/pktgen_sample01_simple.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/pktgen/pktgen_sample01_simple.sh b/samples/pktgen/pktgen_sample01_simple.sh
index cdb9f497f87d..66cb707479e6 100755
--- a/samples/pktgen/pktgen_sample01_simple.sh
+++ b/samples/pktgen/pktgen_sample01_simple.sh
@@ -76,7 +76,7 @@ if [ -n "$DST_PORT" ]; then
     pg_set $DEV "udp_dst_max $UDP_DST_MAX"
 fi
 
-[ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
+[ ! -z "$UDP_CSUM" ] && pg_set $DEV "flag UDPCSUM"
 
 # Setup random UDP port src range
 pg_set $DEV "flag UDPSRC_RND"
-- 
2.34.1

Re: [PATCH net] samples: pktgen: correct dev to DEV

Posted by Jesper Dangaard Brouer 1 year, 2 months ago


On 12/11/2024 04.03, Wei Fang wrote:
> In the pktgen_sample01_simple.sh script, the device variable is uppercase
> 'DEV' instead of lowercase 'dev'. Because of this typo, the script cannot
> enable UDP tx checksum.
> 
> Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
>   samples/pktgen/pktgen_sample01_simple.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/pktgen/pktgen_sample01_simple.sh b/samples/pktgen/pktgen_sample01_simple.sh
> index cdb9f497f87d..66cb707479e6 100755
> --- a/samples/pktgen/pktgen_sample01_simple.sh
> +++ b/samples/pktgen/pktgen_sample01_simple.sh

Why are you only fixing one script?

The fixes commit 460a9aa23de6 changes many files, introducing this bug.

> @@ -76,7 +76,7 @@ if [ -n "$DST_PORT" ]; then
>       pg_set $DEV "udp_dst_max $UDP_DST_MAX"
>   fi
>   
> -[ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
> +[ ! -z "$UDP_CSUM" ] && pg_set $DEV "flag UDPCSUM"
>   

This fix looks correct, but we also need to fix other scripts

>   # Setup random UDP port src range
>   pg_set $DEV "flag UDPSRC_RND"


$ git whatchanged -1 460a9aa23de6 | grep 'M     samples'| awk -FM 
'{print $2}'
	samples/pktgen/parameters.sh
	samples/pktgen/pktgen_sample01_simple.sh
	samples/pktgen/pktgen_sample02_multiqueue.sh
	samples/pktgen/pktgen_sample03_burst_single_flow.sh
	samples/pktgen/pktgen_sample04_many_flows.sh
	samples/pktgen/pktgen_sample05_flow_per_thread.sh
	samples/pktgen/pktgen_sample06_numa_awared_queue_irq_affinity.sh

Thanks for spotting this, but please also fix the other scripts :-)

--Jesper

Re: [PATCH net] samples: pktgen: correct dev to DEV

Posted by Simon Horman 1 year, 2 months ago

On Tue, Nov 12, 2024 at 11:03:47AM +0800, Wei Fang wrote:
> In the pktgen_sample01_simple.sh script, the device variable is uppercase
> 'DEV' instead of lowercase 'dev'. Because of this typo, the script cannot
> enable UDP tx checksum.
> 
> Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>

Reviewed-by: Simon Horman <horms@kernel.org>