hwmon: (acpi_power_meter) Fix fail to load module on platform without _PMD method

[PATCH] hwmon: (acpi_power_meter) Fix fail to load module on platform without _PMD method

Huisong Li posted 1 patch 1 year, 2 months ago

Download mbox

drivers/hwmon/acpi_power_meter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] hwmon: (acpi_power_meter) Fix fail to load module on platform without _PMD method

Posted by Huisong Li 1 year, 2 months ago

As ACPI spec said, _PMD method is optional. The acpi_power_meter
shouldn't fail to load when the platform hasn't _PMD method.

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 drivers/hwmon/acpi_power_meter.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c
index 6c8a9c863528..2f1c9d97ad21 100644
--- a/drivers/hwmon/acpi_power_meter.c
+++ b/drivers/hwmon/acpi_power_meter.c
@@ -680,8 +680,9 @@ static int setup_attrs(struct acpi_power_meter_resource *resource)
 {
 	int res = 0;
 
+	/* _PMD method is optional. */
 	res = read_domain_devices(resource);
-	if (res)
+	if (res != -ENODEV)
 		return res;
 
 	if (resource->caps.flags & POWER_METER_CAN_MEASURE) {
-- 
2.22.0

Re: [PATCH] hwmon: (acpi_power_meter) Fix fail to load module on platform without _PMD method

Posted by Guenter Roeck 1 year, 2 months ago

On Tue, Nov 12, 2024 at 10:12:28AM +0800, Huisong Li wrote:
> As ACPI spec said, _PMD method is optional. The acpi_power_meter
> shouldn't fail to load when the platform hasn't _PMD method.
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>

Applied.

Thanks,
Guenter