1. Patchew
  2. linux
  3. View series

[PATCH] clk: qcom: remove unused data from gcc-ipq5424.c

Arnd Bergmann posted 1 patch 1 year, 2 months ago 
drivers/clk/qcom/gcc-ipq5424.c | 18 ------------------
1 file changed, 18 deletions(-)
[PATCH] clk: qcom: remove unused data from gcc-ipq5424.c
Posted by Arnd Bergmann 1 year, 2 months ago 
From: Arnd Bergmann <arnd@arndb.de>

The newly added driver causes a warnings when enabling -Wunused-const-variables:

drivers/clk/qcom/gcc-ipq5424.c:1064:30: error: 'ftbl_gcc_q6_axi_clk_src' defined but not used [-Werror=unused-const-variable=]
 1064 | static const struct freq_tbl ftbl_gcc_q6_axi_clk_src[] = {
      |                              ^~~~~~~~~~~~~~~~~~~~~~~
drivers/clk/qcom/gcc-ipq5424.c:957:30: error: 'ftbl_gcc_qpic_clk_src' defined but not used [-Werror=unused-const-variable=]
  957 | static const struct freq_tbl ftbl_gcc_qpic_clk_src[] = {
      |                              ^~~~~~~~~~~~~~~~~~~~~
drivers/clk/qcom/gcc-ipq5424.c:497:30: error: 'ftbl_gcc_qupv3_2x_core_clk_src' defined but not used [-Werror=unused-const-variable=]
  497 | static const struct freq_tbl ftbl_gcc_qupv3_2x_core_clk_src[] = {
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In order to hopefully enable this warning by default in the future,
remove the data for now. If it gets used in the future, it can
trivially get added back.

Fixes: 21b5d5a4a311 ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5424 SoC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/qcom/gcc-ipq5424.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/clk/qcom/gcc-ipq5424.c b/drivers/clk/qcom/gcc-ipq5424.c
index 3458c1c98bb7..88a7d5b2e751 100644
--- a/drivers/clk/qcom/gcc-ipq5424.c
+++ b/drivers/clk/qcom/gcc-ipq5424.c
@@ -494,11 +494,6 @@ static struct clk_rcg2 gcc_pcie_aux_clk_src = {
 	},
 };
 
-static const struct freq_tbl ftbl_gcc_qupv3_2x_core_clk_src[] = {
-	F(200000000, P_GPLL0_OUT_MAIN, 4, 0, 0),
-	{ }
-};
-
 static const struct freq_tbl ftbl_gcc_qupv3_i2c0_clk_src[] = {
 	F(4800000, P_XO, 5, 0, 0),
 	F(9600000, P_XO, 2.5, 0, 0),
@@ -954,13 +949,6 @@ static struct clk_rcg2 gcc_qpic_io_macro_clk_src = {
 	},
 };
 
-static const struct freq_tbl ftbl_gcc_qpic_clk_src[] = {
-	F(24000000, P_XO, 1, 0, 0),
-	F(100000000, P_GPLL0_OUT_MAIN, 8, 0, 0),
-	F(200000000, P_GPLL0_OUT_MAIN, 4, 0, 0),
-	{ }
-};
-
 static struct clk_rcg2 gcc_qpic_clk_src = {
 	.cmd_rcgr = 0x32020,
 	.mnd_width = 0,
@@ -1061,12 +1049,6 @@ static struct clk_regmap_div gcc_qupv3_i2c1_div_clk_src = {
 	},
 };
 
-static const struct freq_tbl ftbl_gcc_q6_axi_clk_src[] = {
-	F(480000000, P_GPLL4_OUT_AUX, 2.5, 0, 0),
-	F(533333333, P_GPLL0_OUT_MAIN, 1.5, 0, 0),
-	{ }
-};
-
 static struct clk_regmap_div gcc_usb0_mock_utmi_div_clk_src = {
 	.reg = 0x2c040,
 	.shift = 0,
-- 
2.39.5
Re: [PATCH] clk: qcom: remove unused data from gcc-ipq5424.c
Posted by Bjorn Andersson 1 year, 2 months ago 
On Mon, 11 Nov 2024 11:32:51 +0100, Arnd Bergmann wrote:
> The newly added driver causes a warnings when enabling -Wunused-const-variables:
> 
> drivers/clk/qcom/gcc-ipq5424.c:1064:30: error: 'ftbl_gcc_q6_axi_clk_src' defined but not used [-Werror=unused-const-variable=]
>  1064 | static const struct freq_tbl ftbl_gcc_q6_axi_clk_src[] = {
>       |                              ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-ipq5424.c:957:30: error: 'ftbl_gcc_qpic_clk_src' defined but not used [-Werror=unused-const-variable=]
>   957 | static const struct freq_tbl ftbl_gcc_qpic_clk_src[] = {
>       |                              ^~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-ipq5424.c:497:30: error: 'ftbl_gcc_qupv3_2x_core_clk_src' defined but not used [-Werror=unused-const-variable=]
>   497 | static const struct freq_tbl ftbl_gcc_qupv3_2x_core_clk_src[] = {
>       |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Applied, thanks!

[1/1] clk: qcom: remove unused data from gcc-ipq5424.c
      commit: f1f49cc505bc998d7c13e5a518d027419a21fbae

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH] clk: qcom: remove unused data from gcc-ipq5424.c
Posted by Dmitry Baryshkov 1 year, 2 months ago 
On Mon, Nov 11, 2024 at 11:32:51AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver causes a warnings when enabling -Wunused-const-variables:
> 
> drivers/clk/qcom/gcc-ipq5424.c:1064:30: error: 'ftbl_gcc_q6_axi_clk_src' defined but not used [-Werror=unused-const-variable=]
>  1064 | static const struct freq_tbl ftbl_gcc_q6_axi_clk_src[] = {
>       |                              ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-ipq5424.c:957:30: error: 'ftbl_gcc_qpic_clk_src' defined but not used [-Werror=unused-const-variable=]
>   957 | static const struct freq_tbl ftbl_gcc_qpic_clk_src[] = {
>       |                              ^~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-ipq5424.c:497:30: error: 'ftbl_gcc_qupv3_2x_core_clk_src' defined but not used [-Werror=unused-const-variable=]
>   497 | static const struct freq_tbl ftbl_gcc_qupv3_2x_core_clk_src[] = {
>       |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> In order to hopefully enable this warning by default in the future,
> remove the data for now. If it gets used in the future, it can
> trivially get added back.
> 
> Fixes: 21b5d5a4a311 ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5424 SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/clk/qcom/gcc-ipq5424.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry
Re: [PATCH] clk: qcom: remove unused data from gcc-ipq5424.c
Posted by Sricharan Ramabadhran 1 year, 2 months ago 
Hi Arnd,

On 11/11/2024 6:11 PM, Dmitry Baryshkov wrote:
> On Mon, Nov 11, 2024 at 11:32:51AM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The newly added driver causes a warnings when enabling -Wunused-const-variables:
>>
>> drivers/clk/qcom/gcc-ipq5424.c:1064:30: error: 'ftbl_gcc_q6_axi_clk_src' defined but not used [-Werror=unused-const-variable=]
>>   1064 | static const struct freq_tbl ftbl_gcc_q6_axi_clk_src[] = {
>>        |                              ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/clk/qcom/gcc-ipq5424.c:957:30: error: 'ftbl_gcc_qpic_clk_src' defined but not used [-Werror=unused-const-variable=]
>>    957 | static const struct freq_tbl ftbl_gcc_qpic_clk_src[] = {
>>        |                              ^~~~~~~~~~~~~~~~~~~~~
>> drivers/clk/qcom/gcc-ipq5424.c:497:30: error: 'ftbl_gcc_qupv3_2x_core_clk_src' defined but not used [-Werror=unused-const-variable=]
>>    497 | static const struct freq_tbl ftbl_gcc_qupv3_2x_core_clk_src[] = {
>>        |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> In order to hopefully enable this warning by default in the future,
>> remove the data for now. If it gets used in the future, it can
>> trivially get added back.
>>
>> Fixes: 21b5d5a4a311 ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5424 SoC")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>   drivers/clk/qcom/gcc-ipq5424.c | 18 ------------------
>>   1 file changed, 18 deletions(-)
>>
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 

I already posted a patch here for fixing this [1]

[1] 
https://lore.kernel.org/lkml/xvkvhu3qvlsjnlkiinbm6wguttpozyvlyy5mbbjcpg7vnhrp7w@trjvrm2zpylk/

Regards,
  Sricharan

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.