PCI: mediatek-gen3: Remove unneeded semicolon

[PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon

Posted by Yang Li 1 year, 1 month ago

This patch removes an redundant semicolon.

./drivers/pci/controller/pcie-mediatek-gen3.c:414:2-3: Unneeded
semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11789
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index f333afb92a21..be52e3a123ab 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -411,7 +411,7 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie)
 		if (pcie->num_lanes > 1)
 			val |= FIELD_PREP(PCIE_SETTING_LINK_WIDTH,
 					  GENMASK(fls(pcie->num_lanes >> 2), 0));
-	};
+	}
 	writel_relaxed(val, pcie->base + PCIE_SETTING_REG);
 
 	/* Set Link Control 2 (LNKCTL2) speed restriction, if any */
-- 
2.32.0.3.g01195cf9f

Re: [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon

Posted by Krzysztof Wilczyński 1 year, 1 month ago

Hello,

> This patch removes an redundant semicolon.
> 
> ./drivers/pci/controller/pcie-mediatek-gen3.c:414:2-3: Unneeded
> semicolon

Applied to controller/mediatek, thank you!

[01/01] PCI: mediatek-gen3: Remove unneeded semicolon
        https://git.kernel.org/pci/pci/c/d19ea320d302

	Krzysztof

Re: [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon

Posted by Matthias Brugger 1 year, 1 month ago


On 11/11/2024 02:09, Yang Li wrote:
> This patch removes an redundant semicolon.
> 
> ./drivers/pci/controller/pcie-mediatek-gen3.c:414:2-3: Unneeded
> semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11789
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index f333afb92a21..be52e3a123ab 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -411,7 +411,7 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie)
>   		if (pcie->num_lanes > 1)
>   			val |= FIELD_PREP(PCIE_SETTING_LINK_WIDTH,
>   					  GENMASK(fls(pcie->num_lanes >> 2), 0));
> -	};
> +	}
>   	writel_relaxed(val, pcie->base + PCIE_SETTING_REG);
>   
>   	/* Set Link Control 2 (LNKCTL2) speed restriction, if any */

Re: [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon

Posted by AngeloGioacchino Del Regno 1 year, 1 month ago

Il 11/11/24 02:09, Yang Li ha scritto:
> This patch removes an redundant semicolon.
> 
> ./drivers/pci/controller/pcie-mediatek-gen3.c:414:2-3: Unneeded
> semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11789
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index f333afb92a21..be52e3a123ab 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -411,7 +411,7 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie)
>   		if (pcie->num_lanes > 1)
>   			val |= FIELD_PREP(PCIE_SETTING_LINK_WIDTH,
>   					  GENMASK(fls(pcie->num_lanes >> 2), 0));
> -	};
> +	}
>   	writel_relaxed(val, pcie->base + PCIE_SETTING_REG);
>   
>   	/* Set Link Control 2 (LNKCTL2) speed restriction, if any */