As Christoph suggested, I introduced a new callback to struct bus_type
and hooked up the callbacks directly in virtio and pci subsystem. This
looks pretty neat!
I've decided to provide only one version of blk_mq_hctx_map_queues but
with an additional argument to pass in a driver specific callback.
Currently, there is only one user of this additional callback. Maybe it
would be better to provide an variant of blk_mq_hctx_map_queues for the
additional argument. Not sure though. Thoughts?
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
Changes in v2:
- added new callback to struct bus_type and call directly the affinity
helpers from there.
- Link to v1: https://lore.kernel.org/r/20240913-refactor-blk-affinity-helpers-v1-0-8e058f77af12@suse.de
Changes in v1:
- renamed blk_mq_dev_map_queues to blk_mq_hctx_map_queues
- squased 'virito: add APIs for retrieving vq affinity' into
'blk-mq: introduce blk_mq_hctx_map_queues'
- moved hisi_sas changed into a new patch
- hisi_sas use define instead of hard coded value
- moved helpers into their matching subsystem, removed
blk-mq-pci and blk-mq-virtio files
- fix spelling/typos
- fixed long lines in docu (yep new lines in brief descriptions are
supported, tested ti)
- based on the first part of
https://lore.kernel.org/all/20240806-isolcpus-io-queues-v3-0-da0eecfeaf8b@suse.de
---
Daniel Wagner (6):
blk-mq: introduce blk_mq_hctx_map_queues
scsi: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues
scsi: hisi_sas: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues
nvme: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues
virtio: blk/scsi: replace blk_mq_virtio_map_queues with blk_mq_hctx_map_queues
blk-mq: remove unused queue mapping helpers
block/Makefile | 2 --
block/blk-mq-cpumap.c | 40 +++++++++++++++++++++++++++
block/blk-mq-pci.c | 46 -------------------------------
block/blk-mq-virtio.c | 46 -------------------------------
drivers/block/virtio_blk.c | 4 +--
drivers/nvme/host/fc.c | 1 -
drivers/nvme/host/pci.c | 3 +-
drivers/pci/pci-driver.c | 16 +++++++++++
drivers/scsi/fnic/fnic_main.c | 3 +-
drivers/scsi/hisi_sas/hisi_sas.h | 1 -
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 22 +++++++--------
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 4 +--
drivers/scsi/megaraid/megaraid_sas_base.c | 3 +-
drivers/scsi/mpi3mr/mpi3mr.h | 1 -
drivers/scsi/mpi3mr/mpi3mr_os.c | 3 +-
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 +--
drivers/scsi/pm8001/pm8001_init.c | 2 +-
drivers/scsi/pm8001/pm8001_sas.h | 1 -
drivers/scsi/qla2xxx/qla_nvme.c | 4 +--
drivers/scsi/qla2xxx/qla_os.c | 4 +--
drivers/scsi/smartpqi/smartpqi_init.c | 7 ++---
drivers/scsi/virtio_scsi.c | 3 +-
drivers/virtio/virtio.c | 12 ++++++++
include/linux/blk-mq-pci.h | 11 --------
include/linux/blk-mq-virtio.h | 11 --------
include/linux/blk-mq.h | 5 ++++
include/linux/device/bus.h | 3 ++
27 files changed, 107 insertions(+), 155 deletions(-)
---
base-commit: c9af98a7e8af266bae73e9d662b8341da1ec5824
change-id: 20240912-refactor-blk-affinity-helpers-7089b95b4b10
Best regards,
--
Daniel Wagner <wagi@kernel.org>