[v2] bpf: fix recursive lock and add test

[PATCH bpf v2 0/2] bpf: fix recursive lock and add test

Jiayuan Chen posted 2 patches 2 weeks ago

Diff against v3 v4
Download series mbox

There is a newer version of this series

net/core/skmsg.c                              |  4 +-
.../selftests/bpf/prog_tests/sockmap_basic.c  | 53 +++++++++++++++++++
.../bpf/progs/test_sockmap_pass_prog.c        |  2 +-
3 files changed, 56 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH bpf v2 0/2] bpf: fix recursive lock and add test

Posted by Jiayuan Chen 2 weeks ago

1. fix recursive lock when ebpf prog return SK_PASS.
2. add selftest to reproduce recursive lock.

Note that if just the selftest merged without first
patch, the test case will definitely fail, because the
issue of deadlock is inevitable.

---
v1->v2: 1.inspired by martin.lau to add selftest to reproduce the issue.
        2. follow the community rules for patch.
        v1: https://lore.kernel.org/bpf/55fc6114-7e64-4b65-86d2-92cfd1e9e92f@linux.dev/T/#u
---

Jiayuan Chen (2):
  bpf: fix recursive lock when verdict program return SK_PASS
  selftests/bpf: Add some tests with sockmap SK_PASS

 net/core/skmsg.c                              |  4 +-
 .../selftests/bpf/prog_tests/sockmap_basic.c  | 53 +++++++++++++++++++
 .../bpf/progs/test_sockmap_pass_prog.c        |  2 +-
 3 files changed, 56 insertions(+), 3 deletions(-)

-- 
2.43.5

Re: [PATCH bpf v2 0/2] bpf: fix recursive lock and add test - updated to [PATCH bpf v3]

Posted by Jiayuan Chen 1 week, 6 days ago

On Sat, Nov 09, 2024 at 11:03:03PM +0800, Jiayuan Chen wrote:
> 1. fix recursive lock when ebpf prog return SK_PASS.
> 2. add selftest to reproduce recursive lock.
> 
> Note that if just the selftest merged without first
> patch, the test case will definitely fail, because the
> issue of deadlock is inevitable.
> 
> ---
> v1->v2: 1.inspired by martin.lau to add selftest to reproduce the issue.
>         2. follow the community rules for patch.
>         v1: https://lore.kernel.org/bpf/55fc6114-7e64-4b65-86d2-92cfd1e9e92f@linux.dev/T/#u
> ---
> 
> Jiayuan Chen (2):
>   bpf: fix recursive lock when verdict program return SK_PASS
>   selftests/bpf: Add some tests with sockmap SK_PASS
> 
>  net/core/skmsg.c                              |  4 +-
>  .../selftests/bpf/prog_tests/sockmap_basic.c  | 53 +++++++++++++++++++
>  .../bpf/progs/test_sockmap_pass_prog.c        |  2 +-
>  3 files changed, 56 insertions(+), 3 deletions(-)
> 
> -- 
> 2.43.5

patch v3: https://lore.kernel.org/bpf/20241110082452.40415-1-mrpre@163.com/T/#t