From: Frank Wunderlich <frank-w@public-files.de>

MT7988 has 2 different spi controllers. Add their compatibles.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
index e1f5bfa4433c..ed17815263a8 100644
--- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
+++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
@@ -35,6 +35,8 @@ properties:
           - enum:
               - mediatek,mt7981-spi-ipm
               - mediatek,mt7986-spi-ipm
+              - mediatek,mt7988-spi-quad
+              - mediatek,mt7988-spi-single
               - mediatek,mt8188-spi-ipm
           - const: mediatek,spi-ipm
       - items:
-- 
2.43.0

On Sat, 09 Nov 2024 11:50:28 +0100, Frank Wunderlich wrote:
> MT7988 has 2 different spi controllers. Add their compatibles.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] dt-bindings: spi: add compatibles for mt7988
      commit: 3b2e1b87ad0870ad37ee8f2ca0ea6ede19a29795

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> MT7988 has 2 different spi controllers. Add their compatibles.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index e1f5bfa4433c..ed17815263a8 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -35,6 +35,8 @@ properties:
>            - enum:
>                - mediatek,mt7981-spi-ipm
>                - mediatek,mt7986-spi-ipm
> +              - mediatek,mt7988-spi-quad
> +              - mediatek,mt7988-spi-single
>                - mediatek,mt8188-spi-ipm
>            - const: mediatek,spi-ipm

Does the fallback make sense for both? Is there some common subset of 
functionality where they are the same?

Rob

> Gesendet: Montag, 11. November 2024 um 21:38
&gt; Von: "Rob Herring" <robh@kernel.org>
&gt; An: "Frank Wunderlich" <linux@fw-web.de>
&gt; CC: "Mark Brown" <broonie@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, "Conor Dooley" <conor+dt@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Frank Wunderlich" <frank-w@public-files.de>, "Leilk Liu" <leilk.liu@mediatek.com>, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
&gt; Betreff: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988
&gt;
&gt; On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
&gt; &gt; From: Frank Wunderlich <frank-w@public-files.de>
&gt; &gt;
&gt; &gt; MT7988 has 2 different spi controllers. Add their compatibles.
&gt; &gt;
&gt; &gt; Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
&gt; &gt; ---
&gt; &gt;  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
&gt; &gt;  1 file changed, 2 insertions(+)
&gt; &gt;
&gt; &gt; diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
&gt; &gt; index e1f5bfa4433c..ed17815263a8 100644
&gt; &gt; --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
&gt; &gt; +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
&gt; &gt; @@ -35,6 +35,8 @@ properties:
&gt; &gt;            - enum:
&gt; &gt;                - mediatek,mt7981-spi-ipm
&gt; &gt;                - mediatek,mt7986-spi-ipm
&gt; &gt; +              - mediatek,mt7988-spi-quad
&gt; &gt; +              - mediatek,mt7988-spi-single
&gt; &gt;                - mediatek,mt8188-spi-ipm
&gt; &gt;            - const: mediatek,spi-ipm
&gt;
&gt; Does the fallback make sense for both? Is there some common subset of
&gt; functionality where they are the same?

currently they work only with the fallback compatible, but we see in SDK that there are 2 types...in SDK non-soc specific compatibles are used which was rejected last time.

&gt; Rob
&gt; </frank-w@public-files.de></frank-w@public-files.de></leilk.liu@mediatek.com></frank-w@public-files.de></angelogioacchino.delregno@collabora.com></matthias.bgg@gmail.com></conor+dt@kernel.org></krzk+dt@kernel.org></broonie@kernel.org></linux@fw-web.de></robh@kernel.org>

On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> MT7988 has 2 different spi controllers. Add their compatibles.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Acked-by: Conor Dooley <conor.dooley@microchip.com>