firewall: remove misplaced semicolon from stm32_firewall_get_firewall

[PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall

Posted by guanjing 2 weeks ago

Remove misplaced colon in stm32_firewall_get_firewall()
which results in a syntax error when the code is compiled
without CONFIG_STM32_FIREWALL.

Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
---
 include/linux/bus/stm32_firewall_device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/bus/stm32_firewall_device.h b/include/linux/bus/stm32_firewall_device.h
index 18e0a2fc3816..5178b72bc920 100644
--- a/include/linux/bus/stm32_firewall_device.h
+++ b/include/linux/bus/stm32_firewall_device.h
@@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct stm32_firewall *firewall, u32 su
 #else /* CONFIG_STM32_FIREWALL */
 
 int stm32_firewall_get_firewall(struct device_node *np, struct stm32_firewall *firewall,
-				unsigned int nb_firewall);
+				unsigned int nb_firewall)
 {
 	return -ENODEV;
 }
-- 
2.33.0

Re: [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall

Posted by Alexandre TORGUE 1 week, 4 days ago

Hi

On 11/9/24 06:50, guanjing wrote:
> Remove misplaced colon in stm32_firewall_get_firewall()
> which results in a syntax error when the code is compiled
> without CONFIG_STM32_FIREWALL.
> 
> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
> ---
>   include/linux/bus/stm32_firewall_device.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/bus/stm32_firewall_device.h b/include/linux/bus/stm32_firewall_device.h
> index 18e0a2fc3816..5178b72bc920 100644
> --- a/include/linux/bus/stm32_firewall_device.h
> +++ b/include/linux/bus/stm32_firewall_device.h
> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct stm32_firewall *firewall, u32 su
>   #else /* CONFIG_STM32_FIREWALL */
>   
>   int stm32_firewall_get_firewall(struct device_node *np, struct stm32_firewall *firewall,
> -				unsigned int nb_firewall);
> +				unsigned int nb_firewall)
>   {
>   	return -ENODEV;
>   }

Acked-by: Alexandre Torgue <alexandre.torgue@foss.st.com>

Thanks
Alex

Re: [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall

Posted by Gatien CHEVALLIER 1 week, 4 days ago

On 11/12/24 10:25, Alexandre TORGUE wrote:
> Hi
> 
> On 11/9/24 06:50, guanjing wrote:
>> Remove misplaced colon in stm32_firewall_get_firewall()
>> which results in a syntax error when the code is compiled
>> without CONFIG_STM32_FIREWALL.
>>
>> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
>> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
>> ---
>>   include/linux/bus/stm32_firewall_device.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/bus/stm32_firewall_device.h 
>> b/include/linux/bus/stm32_firewall_device.h
>> index 18e0a2fc3816..5178b72bc920 100644
>> --- a/include/linux/bus/stm32_firewall_device.h
>> +++ b/include/linux/bus/stm32_firewall_device.h
>> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct 
>> stm32_firewall *firewall, u32 su
>>   #else /* CONFIG_STM32_FIREWALL */
>>   int stm32_firewall_get_firewall(struct device_node *np, struct 
>> stm32_firewall *firewall,
>> -                unsigned int nb_firewall);
>> +                unsigned int nb_firewall)
>>   {
>>       return -ENODEV;
>>   }
> 
> Acked-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> 
> Thanks
> Alex

Hi, please use get_maintainers.pl script next time so that
adequate people are put in To/CC.
Nevertheless, thanks for the patch!

Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com>

Re: [PATCH v2] firewall: remove misplaced semicolon fromstm32_firewall_get_firewall

Posted by guanjing 2 days, 10 hours ago

Thanks for your advice. I apologize for the omission. :)


On 2024/11/12 17:40, Gatien CHEVALLIER wrote:
> On 11/12/24 10:25, Alexandre TORGUE wrote:
>> Hi
>>
>> On 11/9/24 06:50, guanjing wrote:
>>> Remove misplaced colon in stm32_firewall_get_firewall()
>>> which results in a syntax error when the code is compiled
>>> without CONFIG_STM32_FIREWALL.
>>>
>>> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
>>> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
>>> ---
>>>   include/linux/bus/stm32_firewall_device.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/bus/stm32_firewall_device.h 
>>> b/include/linux/bus/stm32_firewall_device.h
>>> index 18e0a2fc3816..5178b72bc920 100644
>>> --- a/include/linux/bus/stm32_firewall_device.h
>>> +++ b/include/linux/bus/stm32_firewall_device.h
>>> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct 
>>> stm32_firewall *firewall, u32 su
>>>   #else /* CONFIG_STM32_FIREWALL */
>>>   int stm32_firewall_get_firewall(struct device_node *np, struct 
>>> stm32_firewall *firewall,
>>> -                unsigned int nb_firewall);
>>> +                unsigned int nb_firewall)
>>>   {
>>>       return -ENODEV;
>>>   }
>>
>> Acked-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
>> Thanks
>> Alex
>
> Hi, please use get_maintainers.pl script next time so that
> adequate people are put in To/CC.
> Nevertheless, thanks for the patch!
>
> Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com>

Re: [PATCH v2] firewall: remove misplaced semicolon fromstm32_firewall_get_firewall

Posted by Jeff Johnson 1 day, 22 hours ago

On 11/21/2024 1:19 AM, guanjing wrote:
> Thanks for your advice. I apologize for the omission. :)

Please avoid top-posting

https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions