Remove misplaced colon in inline variant of pruss_cfg_xfr_enable()
which results in a syntax error when the code is compiled without
CONFIG_TI_PRUSS.

Fixes: 0211cc1e4fbb ("soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR")
Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
---
 include/linux/pruss_driver.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pruss_driver.h b/include/linux/pruss_driver.h
index c9a31c567e85..29a76a60869c 100644
--- a/include/linux/pruss_driver.h
+++ b/include/linux/pruss_driver.h
@@ -167,7 +167,7 @@ static inline int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable)
 
 static inline int pruss_cfg_xfr_enable(struct pruss *pruss,
 				       enum pru_type pru_type,
-				       bool enable);
+				       bool enable)
 {
 	return ERR_PTR(-EOPNOTSUPP);
 }
-- 
2.33.0

On 09/11/2024 05:26, guanjing wrote:
> Remove misplaced colon in inline variant of pruss_cfg_xfr_enable()

s/colon/semicolon

> which results in a syntax error when the code is compiled without
> CONFIG_TI_PRUSS.
> 
> Fixes: 0211cc1e4fbb ("soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR")
> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

On 14:32-20241111, Roger Quadros wrote:
> 
> 
> On 09/11/2024 05:26, guanjing wrote:
> > Remove misplaced colon in inline variant of pruss_cfg_xfr_enable()
> 
> s/colon/semicolon
> 
> > which results in a syntax error when the code is compiled without
> > CONFIG_TI_PRUSS.
> > 
> > Fixes: 0211cc1e4fbb ("soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR")
> > Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
> 
> Reviewed-by: Roger Quadros <rogerq@kernel.org>

https://lore.kernel.org/all/Zy3nBW3XvFy-Y1Fe@kernel.org/

Please also add to the commit message what Simon suggested (Found using ..)
- how was this found? That helps other folks learn better practises.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D