[PATCH v7 06/10] perf evsel: Assemble offcpu samples

Howard Chu posted 10 patches 2 weeks, 1 day ago
There is a newer version of this series
[PATCH v7 06/10] perf evsel: Assemble offcpu samples
Posted by Howard Chu 2 weeks, 1 day ago
Use the data in bpf-output samples, to assemble offcpu samples.

Suggested-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Howard Chu <howardchu95@gmail.com>
---
 tools/perf/util/evsel.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 695f831b463d..20f07597fac1 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2783,6 +2783,35 @@ static inline bool evsel__has_branch_counters(const struct evsel *evsel)
 	return false;
 }
 
+static int __set_offcpu_sample(struct perf_sample *data)
+{
+	u64 *array = data->raw_data;
+	u32 max_size = data->raw_size, *p32;
+	const void *endp = (void *)array + max_size;
+
+	if (array == NULL)
+		return -EFAULT;
+
+	OVERFLOW_CHECK_u64(array);
+	p32 = (void *)array++;
+	data->pid = p32[0];
+	data->tid = p32[1];
+
+	OVERFLOW_CHECK_u64(array);
+	data->period = *array++;
+
+	OVERFLOW_CHECK_u64(array);
+	data->callchain = (struct ip_callchain *)array++;
+	OVERFLOW_CHECK(array, data->callchain->nr * sizeof(u64), max_size);
+	data->ip = data->callchain->ips[1];
+	array += data->callchain->nr;
+
+	OVERFLOW_CHECK_u64(array);
+	data->cgroup = *array;
+
+	return 0;
+}
+
 int evsel__parse_sample(struct evsel *evsel, union perf_event *event,
 			struct perf_sample *data)
 {
@@ -3134,6 +3163,9 @@ int evsel__parse_sample(struct evsel *evsel, union perf_event *event,
 		array = (void *)array + sz;
 	}
 
+	if (evsel__is_offcpu_event(evsel))
+		return __set_offcpu_sample(data);
+
 	return 0;
 }
 
-- 
2.43.0
Re: [PATCH v7 06/10] perf evsel: Assemble offcpu samples
Posted by Ian Rogers 1 week, 5 days ago
On Fri, Nov 8, 2024 at 12:41 PM Howard Chu <howardchu95@gmail.com> wrote:
>
> Use the data in bpf-output samples, to assemble offcpu samples.
>
> Suggested-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Howard Chu <howardchu95@gmail.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/util/evsel.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 695f831b463d..20f07597fac1 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -2783,6 +2783,35 @@ static inline bool evsel__has_branch_counters(const struct evsel *evsel)
>         return false;
>  }
>
> +static int __set_offcpu_sample(struct perf_sample *data)
> +{
> +       u64 *array = data->raw_data;
> +       u32 max_size = data->raw_size, *p32;
> +       const void *endp = (void *)array + max_size;
> +
> +       if (array == NULL)
> +               return -EFAULT;
> +
> +       OVERFLOW_CHECK_u64(array);
> +       p32 = (void *)array++;
> +       data->pid = p32[0];
> +       data->tid = p32[1];
> +
> +       OVERFLOW_CHECK_u64(array);
> +       data->period = *array++;
> +
> +       OVERFLOW_CHECK_u64(array);
> +       data->callchain = (struct ip_callchain *)array++;
> +       OVERFLOW_CHECK(array, data->callchain->nr * sizeof(u64), max_size);
> +       data->ip = data->callchain->ips[1];
> +       array += data->callchain->nr;
> +
> +       OVERFLOW_CHECK_u64(array);
> +       data->cgroup = *array;
> +
> +       return 0;
> +}
> +
>  int evsel__parse_sample(struct evsel *evsel, union perf_event *event,
>                         struct perf_sample *data)
>  {
> @@ -3134,6 +3163,9 @@ int evsel__parse_sample(struct evsel *evsel, union perf_event *event,
>                 array = (void *)array + sz;
>         }
>
> +       if (evsel__is_offcpu_event(evsel))
> +               return __set_offcpu_sample(data);
> +
>         return 0;
>  }
>
> --
> 2.43.0
>