[PATCH v4 3/6] arm64: Add Blaize BLZP1600 SoC family

Niko Pasaloukos posted 6 patches 2 weeks, 1 day ago
[PATCH v4 3/6] arm64: Add Blaize BLZP1600 SoC family
Posted by Niko Pasaloukos 2 weeks, 1 day ago
Add ARCH_BLAIZE_BLZP1600 SoC family to the arm64 architecture.

Resolves: PESW-2604
Checkpatch: ignore

Reviewed-by: James Cowgill <james.cowgill@blaize.com>
Reviewed-by: Matt Redfearn <matt.redfearn@blaize.com>
Reviewed-by: Neil Jones <neil.jones@blaize.com>
Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
---
 arch/arm64/Kconfig.platforms | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 24335565bad5..c2a523637b23 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -94,6 +94,11 @@ config ARCH_BITMAIN
 	help
 	  This enables support for the Bitmain SoC Family.
 
+config ARCH_BLAIZE_BLZP1600
+	bool "Blaize BLZP1600 SoC Platforms"
+	help
+	  This enables support for the Blaize BLZP1600 SoC family
+
 config ARCH_EXYNOS
 	bool "Samsung Exynos SoC family"
 	select COMMON_CLK_SAMSUNG
-- 
2.43.0
Re: [PATCH v4 3/6] arm64: Add Blaize BLZP1600 SoC family
Posted by Krzysztof Kozlowski 2 weeks, 1 day ago
On 08/11/2024 11:31, Niko Pasaloukos wrote:
> Add ARCH_BLAIZE_BLZP1600 SoC family to the arm64 architecture.
> 
> Resolves: PESW-2604
> Checkpatch: ignore

NAK.

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

> 
> Reviewed-by: James Cowgill <james.cowgill@blaize.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@blaize.com>
> Reviewed-by: Neil Jones <neil.jones@blaize.com>

Are these real reviews?

Best regards,
Krzysztof