[v1] net: rfkill: gpio: Add check for clk_enable()

[PATCH] net: rfkill: gpio: Add check for clk_enable()

Mingwei Zheng posted 1 patch 2 weeks, 2 days ago

Diff against v1 v2 v3
Download mbox

There is a newer version of this series

net/rfkill/rfkill-gpio.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] net: rfkill: gpio: Add check for clk_enable()

Posted by Mingwei Zheng 2 weeks, 2 days ago

Add check for the return value of clk_enable() to catch the potential
expection.

Fixes: 7176ba23f8b5 ("net: rfkill: add generic gpio rfkill driver")
Signed-off-by: Mingwei Zheng <zmw12306@gmail.com>
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
 net/rfkill/rfkill-gpio.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index c268c2b011f4..a87bb99231a6 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -31,9 +31,13 @@ struct rfkill_gpio_data {
 static int rfkill_gpio_set_power(void *data, bool blocked)
 {
 	struct rfkill_gpio_data *rfkill = data;
+	int ret;
 
-	if (!blocked && !IS_ERR(rfkill->clk) && !rfkill->clk_enabled)
-		clk_enable(rfkill->clk);
+	if (!blocked && !IS_ERR(rfkill->clk) && !rfkill->clk_enabled) {
+		ret = clk_enable(rfkill->clk);
+		if (!ret)
+			return ret;
+	}
 
 	gpiod_set_value_cansleep(rfkill->shutdown_gpio, !blocked);
 	gpiod_set_value_cansleep(rfkill->reset_gpio, !blocked);
-- 
2.34.1

Re: [PATCH] net: rfkill: gpio: Add check for clk_enable()

Posted by Johannes Berg 2 weeks, 2 days ago

On Thu, 2024-11-07 at 16:01 -0500, Mingwei Zheng wrote:
> Add check for the return value of clk_enable() to catch the potential
> expection.

"exception"? but we don't have exceptions? "error"?

johannes