vdpa: vdpa_sim: vdpa_sim_net: fixed cofing style issues

[PATCH] vdpa: vdpa_sim: vdpa_sim_net: fixed cofing style issues

Posted by Gediminas Repecka 2 weeks, 2 days ago

Fixed coding style issues reported by checkpatch script
---
 drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
index 6caf09a1907b..0705aff74cf3 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
@@ -53,7 +53,7 @@ struct vdpasim_cq_stats {
 	u64 errors;
 };

-struct vdpasim_net{
+struct vdpasim_net {
 	struct vdpasim vdpasim;
 	struct vdpasim_dataq_stats tx_stats;
 	struct vdpasim_dataq_stats rx_stats;
@@ -293,7 +293,7 @@ static int vdpasim_net_get_stats(struct vdpasim *vdpasim, u16 idx,
 	unsigned int start;
 	int err = -EMSGSIZE;

-	switch(idx) {
+	switch (idx) {
 	case 0:
 		do {
 			start = u64_stats_fetch_begin(&net->rx_stats.syncp);
@@ -543,7 +543,7 @@ static struct vdpa_mgmt_dev mgmt_dev = {
 	.ops = &vdpasim_net_mgmtdev_ops,
 	.config_attr_mask = (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR |
 			     1 << VDPA_ATTR_DEV_NET_CFG_MTU |
-		             1 << VDPA_ATTR_DEV_FEATURES),
+			     1 << VDPA_ATTR_DEV_FEATURES),
 	.max_supported_vqs = VDPASIM_NET_VQ_NUM,
 	.supported_features = VDPASIM_NET_FEATURES,
 };

2.34.1

Re: [PATCH] vdpa: vdpa_sim: vdpa_sim_net: fixed cofing style issues

Posted by Michael S. Tsirkin 1 week, 4 days ago

On Thu, Nov 07, 2024 at 09:19:41PM +0200, Gediminas Repecka wrote:
> Fixed coding style issues reported by checkpatch script
> ---

A lot is wrong with this submission, given it's supposed to fix
checkpatch:

- no signature
- typo in subject
- not using direct voice (Fix, not Fixed)


pls fix and resubmit

>  drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> index 6caf09a1907b..0705aff74cf3 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> @@ -53,7 +53,7 @@ struct vdpasim_cq_stats {
>  	u64 errors;
>  };
> 
> -struct vdpasim_net{
> +struct vdpasim_net {
>  	struct vdpasim vdpasim;
>  	struct vdpasim_dataq_stats tx_stats;
>  	struct vdpasim_dataq_stats rx_stats;
> @@ -293,7 +293,7 @@ static int vdpasim_net_get_stats(struct vdpasim *vdpasim, u16 idx,
>  	unsigned int start;
>  	int err = -EMSGSIZE;
> 
> -	switch(idx) {
> +	switch (idx) {
>  	case 0:
>  		do {
>  			start = u64_stats_fetch_begin(&net->rx_stats.syncp);
> @@ -543,7 +543,7 @@ static struct vdpa_mgmt_dev mgmt_dev = {
>  	.ops = &vdpasim_net_mgmtdev_ops,
>  	.config_attr_mask = (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR |
>  			     1 << VDPA_ATTR_DEV_NET_CFG_MTU |
> -		             1 << VDPA_ATTR_DEV_FEATURES),
> +			     1 << VDPA_ATTR_DEV_FEATURES),
>  	.max_supported_vqs = VDPASIM_NET_VQ_NUM,
>  	.supported_features = VDPASIM_NET_FEATURES,
>  };
> 
> 2.34.1